Skip to content

fix(streams): Cancel internal stream pumps before releasing their source - #7165

Merged
sohpeach merged 1 commit into
swallace/patch-wrappable-shimsfrom
swallace/patch-stream-pump-cancel
Aug 28, 2026
Merged

fix(streams): Cancel internal stream pumps before releasing their source#7165
sohpeach merged 1 commit into
swallace/patch-wrappable-shimsfrom
swallace/patch-stream-pump-cancel

Conversation

@sohpeach

Copy link
Copy Markdown
Member

Merging from upstream.

This prevents pumpTo() from resuming with a dangling ReadableStreamSource pointer after forceCancel().

@sohpeach
sohpeach requested review from a team as code owners August 28, 2026 09:25
@ask-bonk

ask-bonk Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@codecov-commenter

codecov-commenter commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.06%. Comparing base (99e1257) to head (3354a8d).

Files with missing lines Patch % Lines
src/workerd/api/streams/internal-test.c++ 80.43% 0 Missing and 9 partials ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           swallace/patch-wrappable-shims    #7165   +/-   ##
===============================================================
  Coverage                           35.05%   35.06%           
===============================================================
  Files                                 811      811           
  Lines                              258829   258885   +56     
  Branches                            21616    21625    +9     
===============================================================
+ Hits                                90735    90777   +42     
  Misses                             154975   154975           
- Partials                            13119    13133   +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sohpeach
sohpeach force-pushed the swallace/patch-stream-pump-cancel branch 2 times, most recently from 339348b to 679e09b Compare August 28, 2026 10:55
This prevents pumpTo() from resuming with a dangling ReadableStreamSource pointer after forceCancel().
@sohpeach
sohpeach force-pushed the swallace/patch-stream-pump-cancel branch from 679e09b to 3354a8d Compare August 28, 2026 11:39
@sohpeach
sohpeach merged commit 1b0594c into main Aug 28, 2026
26 of 28 checks passed
@sohpeach
sohpeach deleted the swallace/patch-stream-pump-cancel branch August 28, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants