Skip to content

Add compression streams suite; migrate existing CS/DS tests - #7155

Open
jasnell wants to merge 9 commits into
jasnell/streams-test-consolidation-2from
jasnell/streams-test-consolidation-3
Open

Add compression streams suite; migrate existing CS/DS tests#7155
jasnell wants to merge 9 commits into
jasnell/streams-test-consolidation-2from
jasnell/streams-test-consolidation-3

Conversation

@jasnell

@jasnell jasnell commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

More test consolidation/improvement. Comparing legacy C++ impl with TS

@jasnell
jasnell requested review from a team as code owners August 27, 2026 22:34
Comment thread src/per_isolate/webstreams/compression.ts
Comment thread src/per_isolate/webstreams/compression.ts
@ask-bonk

ask-bonk Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Consolidates compression-stream tests and adds TS write-time chunk snapshots.

  1. [HIGH] Posted 2 inline review comments on PR Add compression streams suite; migrate existing CS/DS tests #7155.
  2. Targeted test build was blocked by the environment’s missing libc++ headers.

github run

@jasnell

jasnell commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Includes a fix for both compression and identity streams that was flagged by the AI reviewer.

@guybedford guybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suite — coverage is a strict superset of the deleted tests and the divergence pinning is exactly right. Two minor notes inline.

Comment thread src/tests/streams/compression/body-integration.js Outdated
Comment thread src/per_isolate/webstreams/compression.ts Outdated
@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-3 branch from f412e19 to 1ddfd87 Compare August 28, 2026 13:49
@codecov-commenter

codecov-commenter commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.97%. Comparing base (0e26ff0) to head (a796d03).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           jasnell/streams-test-consolidation-2    #7155      +/-   ##
========================================================================
+ Coverage                                 35.85%   35.97%   +0.12%     
========================================================================
  Files                                       811      808       -3     
  Lines                                    258802   257643    -1159     
  Branches                                  19572    19572              
========================================================================
- Hits                                      92802    92699     -103     
+ Misses                                   154924   153863    -1061     
- Partials                                  11076    11081       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
jasnell force-pushed the jasnell/streams-test-consolidation-3 branch from 1ddfd87 to d9c421e Compare August 28, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants