Add compression streams suite; migrate existing CS/DS tests - #7155
Open
jasnell wants to merge 9 commits into
Open
Add compression streams suite; migrate existing CS/DS tests#7155jasnell wants to merge 9 commits into
jasnell wants to merge 9 commits into
Conversation
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Consolidates compression-stream tests and adds TS write-time chunk snapshots.
|
Collaborator
Author
|
Includes a fix for both compression and identity streams that was flagged by the AI reviewer. |
guybedford
approved these changes
Aug 28, 2026
guybedford
left a comment
Contributor
There was a problem hiding this comment.
Nice suite — coverage is a strict superset of the deleted tests and the divergence pinning is exactly right. Two minor notes inline.
jasnell
force-pushed
the
jasnell/streams-test-consolidation-3
branch
from
August 28, 2026 13:49
f412e19 to
1ddfd87
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jasnell/streams-test-consolidation-2 #7155 +/- ##
========================================================================
+ Coverage 35.85% 35.97% +0.12%
========================================================================
Files 811 808 -3
Lines 258802 257643 -1159
Branches 19572 19572
========================================================================
- Hits 92802 92699 -103
+ Misses 154924 153863 -1061
- Partials 11076 11081 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jasnell
force-pushed
the
jasnell/streams-test-consolidation-3
branch
from
August 28, 2026 15:04
1ddfd87 to
d9c421e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More test consolidation/improvement. Comparing legacy C++ impl with TS