Add encoding streams suite; migrate existing TES/TDS tests - #7154
Open
jasnell wants to merge 12 commits into
Open
Add encoding streams suite; migrate existing TES/TDS tests#7154jasnell wants to merge 12 commits into
jasnell wants to merge 12 commits into
Conversation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Consolidates encoding-stream tests into shared C++/TypeScript suites.
|
guybedford
reviewed
Aug 28, 2026
jasnell
force-pushed
the
jasnell/streams-test-consolidation-2
branch
from
August 28, 2026 13:49
d92bb20 to
a847471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next test consolidation set..
TextEncoderStreamandTextDecoderStreamcombined C++/TS suite. Following in the footsteps of the identity suite that already landed.The fact that only 169 LOC were removed here compared to 2188 added goes to show we weren't really testing this API nearly well enough. Yay moar coverage!