Fix Node global declarations in workers types - #7149
Open
xgame92 wants to merge 2 commits into
Open
Conversation
Author
|
Could a maintainer approve the workflow runs? The Linux check-snapshot artifact is needed to regenerate the types snapshot; the Bazel types target is marked incompatible on Windows because of rtti_capnp_js. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7026
Buffer, process, and global are also declared by @types/node using the var declaration kind. Emit the same declaration kind for those three names so TypeScript can merge the declarations, while preserving const for Workers and DOM globals.
Adds a transformer regression test covering the three Node globals and a non-Node control.
Testing: