Simplify build configuration - #16
Conversation
7a8fbca to
0dfaa56
Compare
ebdae6b to
1db9901
Compare
|
Looks like the Windows build is failing for Windows reasons (according to Sonnet):
But maybe that's fine since workerd doesn't use the clang-tidy Windows binary anyway? I have no reason to assume that the changes here are responsible for the failure. |
|
If it's a flake as the clanker says, maybe we can re-run your test job and see if it disappears? |
|
Also why the fuck would GitHub be running Windows Defender in CI? Can we nuke it somehow? If this is true I think we can make things way faster. |
1db9901 to
b5f8a4f
Compare
- Use ubuntu-24.04 runner so we get a more recent clang version - Use native arm64 build, getting rid of zig - Remove setup steps for dependencies that are already installed on the runner images - CLANG_ENABLE_ARCMT is deprecated, don't attempt to disable it - Fix thinLTO support
b5f8a4f to
d3754ed
Compare
|
Turns out that explanation was wrong – the actual issue appears to be actions/runner-images#11102, the latest commit contains a workaround and the Windows job passed https://github.com/cloudflare/workerd-tools/actions/runs/33019715585/job/98346819585 |
Uh oh!
There was an error while loading. Please reload this page.