fix: use ESM specifiers for NodeNext module resolution#194
Draft
LordCoughmann wants to merge 3 commits into
Draft
fix: use ESM specifiers for NodeNext module resolution#194LordCoughmann wants to merge 3 commits into
LordCoughmann wants to merge 3 commits into
Conversation
Extension-less imports in declaration files fail with moduleResolution: NodeNext, causing TypeScript to report: Module '"@cloudflare/playwright"' has no exported member 'Browser'. Fix all declaration files: - Hand-written: index.d.ts, test.d.ts, internal.d.ts - Generated: add post-processing step in copy_types.js to rewrite relative specifiers with .d.ts extensions, with assertion guard - Package exports: add ./types/types entry in package.json
LordCoughmann
force-pushed
the
fix/esm-type-resolution
branch
from
June 5, 2026 07:38
6959dfe to
bc289eb
Compare
18 tasks
Author
|
While validating the published package shape, we noticed a separate issue: strict TypeScript consumers importing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Extension-less relative imports in the package declaration files fail with
moduleResolution: NodeNextorNode16:Reproduction: https://github.com/LordCoughmann/repo-cf-playwright-esm-nodenext
Solution
Use explicit ESM
.jsspecifiers in declaration files. TypeScript's NodeNext resolver maps these specifiers to the corresponding.d.tsfiles, while.d.tsspecifiers themselves are rejected for value imports and exports withTS2846..jsspecifiers..jsextensions to relativefrom,declare module, and dynamicimport()specifiers.skipLibCheck.NodeNextconsumer fixture covering the package root entry point.Validation
Both pass with
moduleResolution: NodeNextandskipLibCheck: false.