Skip to content

chore: update OpenAPI to 15656f084dd7 - #339

Open
ant-release-bot wants to merge 1 commit into
mainfrom
automation/update-forge
Open

ant-release-bot wants to merge 1 commit into
mainfrom
automation/update-forge

Conversation

@ant-release-bot

@ant-release-bot ant-release-bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Updates cf to openapi@15656f084dd7a0ada54f8f659c749a7248254b9f.

  • pins OpenAPI revision 15656f084dd7a0ada54f8f659c749a7248254b9f
  • regenerates the committed command surface with the pinned Forge package

This PR is maintained automatically by the Update OpenAPI workflow.

@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/cf@339

commit: a41bb7a

.command($fonts)
.command($h2prioritization)
.command($holds)
.command($hostnames)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checked-in hostname E2E fixture and generated runner still invoke cf hostnames ... (for example, run-e2e.sh lines 5393-5414). This change removes hostnames from the generated root registry, so bash packages/cli/e2e/_generated/run-e2e.sh --product hostnames now fails every scenario with an unknown command instead of exercising these endpoints. Update packages/cli/e2e/hostnames.json and regenerate its runner to use cf zones hostnames ... (including the current --setting-id arguments for hostname-specific requests), or preserve a root alias through Forge before regenerating.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

cf --help startup

mean stddev min max
PR 262.6 ms 3.5 ms 257.3 ms 267.5 ms
base 261.0 ms 3.4 ms 256.9 ms 270.6 ms

Δ (PR vs base): ↑ +1.6 ms (+0.6%)

Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.

@ask-bonk

ask-bonk Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Review: 1 findings.

Posted 1 inline warning.

github run

@clanky-the-clanker

clanky-the-clanker Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

💬 Approved with comments — Regeneration is consistent and the changes are safe to merge. One WARNING: the changeset doesn't mention that the visible cf hostnames root moved to cf zones hostnames, which breaks existing invocations. One INFO: an out-of-band e2e fixture is stale.

Findings: 1 warning · 1 info

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.

🔧 Fix with your agent

Paste the following into your coding agent to investigate and fix these issues.

Fix the following code review issues found in pull request #339.

Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
  for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

## WARNING (1)

### [Release] The changeset doesn't mention that the visible `cf hostnames settings tls|tls-single ...` commands moved to `cf zones hostnames settings ...`. Existing invocations will fail under strict yargs, and `.changeset/README.md` requires beta breaking changes to be called out.
- **File:** .changeset/update-openapi-15656f084dd7.md:5

## INFO (1)

### [Code Quality] `packages/cli/e2e/hostnames.json` still invokes `cf hostnames settings ...`, which no longer exists now that the commands live under `cf zones hostnames`. The suite runs out-of-band, so this is informational.
- **File:** packages/cli/e2e/hostnames.json

🚀 Release: ⚠️ 1 warning

The changeset doesn't mention the breaking move of cf hostnames ... to cf zones hostnames ....

Recommendation: 📝 Minor Comments

  • [WARNING] The changeset doesn't mention that the visible cf hostnames settings tls|tls-single ... commands moved to cf zones hostnames settings .... Existing invocations will fail under strict yargs, and .changeset/README.md requires beta breaking changes to be called out. (.changeset/update-openapi-15656f084dd7.md:5)
View full review

Risk: Medium

What changes for users

  • The visible top-level cf hostnames root is removed (packages/cli/src/commands/_generated/index.ts). Its TLS settings commands now live at cf zones hostnames settings tls|tls-single get|update|delete (packages/cli/src/commands/_generated/zones/index.ts).
  • yargs.strict() is on, so scripts and agents that call the old path will fail. Telemetry command names change as well.

What the changeset says

  • .changeset/update-openapi-15656f084dd7.md is a minor bump, which matches the beta policy for breaking changes.
  • Its body only says "Update the generated command surface". .changeset/README.md says breaking changes during the 1.0 beta must be called out.
  • Add a line along the lines of: "cf hostnames settings ... has moved to cf zones hostnames settings ...."
  • The changeset is written by automation, so it may need to be edited by hand, or the updater could learn to detect removed visible roots.

📋 Code Quality: 💬 1 info

The regenerated output is mechanically consistent. An out-of-band e2e fixture still calls the removed cf hostnames root.

Recommendation: 💬 Optional Nits

  • [INFO] packages/cli/e2e/hostnames.json still invokes cf hostnames settings ..., which no longer exists now that the commands live under cf zones hostnames. The suite runs out-of-band, so this is informational. (packages/cli/e2e/hostnames.json)
View full review

What the generated changes do

  • The pin bump moves the hostname TLS settings commands from the top-level cf hostnames root to cf zones hostnames settings tls|tls-single .... The entry with hideCommand: false is removed from _generated/index.ts, and zones/index.ts and zones/hostnames/index.ts register the commands under their new path.
  • Usage strings, telemetry command names, dry-run output, operation import paths and @generated comments all point at the new path consistently.
  • No hand-written source under packages/cli/src imports the old _generated/hostnames paths.
  • The cloudforce-one/threat-signals changes cover:
    • updated descriptions
    • a few new list and filter flags
    • custom confirmation messages on feeds delete and skills delete
  • None of the threat-signals files that were read showed correctness problems. This review did not cover the commands.json and schemas.json diffs line by line.

Stale e2e fixture

  • packages/cli/e2e/hostnames.json still invokes cf hostnames settings ..., a root that no longer exists.
  • The fixture's leaf names were already out of date before this pull request, and the e2e suite runs out-of-band, so this does not block.
  • Update it to cf zones hostnames ... the next time the fixtures are refreshed.

✅ All other checks passed

🔒 Security: ✅ LGTM

  • In generate.ts, only the pinned OpenAPI release SHA changes. The download URL is still built from a fixed release path.
  • The hostnames → zones hostnames move only renames command and import paths. Request URLs, auth handling and zone resolution (getZoneId) are unchanged.
  • The threat-signals changes are description and prompt-text updates plus new query flags, all handled by the existing generic request runtime.

📖 AGENTS.md: ✅ LGTM

This pull request doesn't change anything that AGENTS.md describes, so no guidance updates are needed.


⚡ Performance: ✅ LGTM

This change has no performance impact. One fewer lazy root is registered, and the moved commands load lazily through the existing zones root.


📝 Documentation: ✅ LGTM

No documentation files are affected beyond the changeset. The changeset itself is covered in the release section.


Reviewed commit: a41bb7ad

@ant-release-bot ant-release-bot changed the title chore: update OpenAPI to 02d56254b3fd chore: update OpenAPI to 15656f084dd7 Oct 17, 2026
@ant-release-bot
ant-release-bot force-pushed the automation/update-forge branch from 8b82b6f to a41bb7a Compare October 17, 2026 01:01
@ask-bonk

ask-bonk Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

No new concerns since the last review

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant