Skip to content

chore: add anti-slop Oxlint rules - #2163

Open
mattzcarey wants to merge 1 commit into
cloudflare:mainfrom
mattzcarey:chore/install-anti-slop
Open

chore: add anti-slop Oxlint rules#2163
mattzcarey wants to merge 1 commit into
cloudflare:mainfrom
mattzcarey:chore/install-anti-slop

Conversation

@mattzcarey

Copy link
Copy Markdown
Contributor

Summary

  • vendor the generic and Effect anti-slop Oxlint plugins under tools/oxlint/anti-slop
  • pin matching oxlint and @oxlint/plugins 1.80.0 releases and register the plugins in the normal root lint configuration
  • enable six generic rules plus the Effect service-import rule, with narrow file overrides for existing proxy, prototype-call, and module-mocking cases
  • keep high-volume migration rules explicitly disabled and document the initial findings and rationale in tools/oxlint/anti-slop/README.md
  • preserve the existing React lint policy across the Oxlint upgrade, add formatter/tooling ignores, and record the vendored MIT license
  • fix several tractable findings in Agents, Think, and Voice code and tests

A strict initial scan found 13,205 existing anti-slop findings across 824 files. This PR enables the rules the repository can adopt cleanly now. The remaining rules stay visible as off rather than disappearing from the configuration, so they can be migrated package by package.

No changeset is included because this changes repository tooling and internal implementation details without changing package behavior or public APIs.

Verification

  • pnpm run build
  • pnpm run check with Node 24.14.1, including all 114 TypeScript projects
  • pnpm exec nx affected -t test, covering 22 affected projects
  • focused Agents, Think, Voice, and Plivo tests
  • temporary violating-file smoke test confirming an enabled anti-slop rule rejects code through the normal root configuration

@changeset-bot

changeset-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9fa430a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant