feat(taskprocessing): add option for user-facing error message#452
feat(taskprocessing): add option for user-facing error message#452kyteinsky wants to merge 1 commit into
Conversation
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTask processing result reporting now accepts an optional user-facing error message in both synchronous and asynchronous APIs and sends it to Nextcloud as ChangesTask result reporting
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I actually created the exact same pr 🤣, but feel free to use yours its the exact same code anyway (#450) |
|
ah damn, missed that one. let's merge yours, it came first 🥇 |
I just pushed that, but as I don't have any access to this repo you might need to merge it yourself. |
Corresponding API in the server: https://github.com/nextcloud/server/blob/72b89abd47512e9cc337401133d9487996e6f119/core/Controller/TaskProcessingApiController.php#L637
Changes proposed in this pull request:
report_resultSummary by CodeRabbit