Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,16 @@ describe('appEventsService', () => {
data: expect.objectContaining({ args: payload }),
}))
})

describe('emit surface (migration parity)', () => {
const expectedEmitMethods = ['emitProjectEvent', 'emitProjectMemberEvent', 'emitRepositoryEvent'] as const

it.each(expectedEmitMethods)('exposes %s as a public emit entrypoint', (method) => {
expect(typeof service[method]).toBe('function')
})

it('does NOT expose a zone emit entrypoint (zone.* listeners have no emitter yet — legacy owns the route)', () => {
expect('emitZoneEvent' in service).toBe(false)
})
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -526,4 +526,34 @@ describe('keycloakService', () => {
expect(keycloak.removeUserFromGroup).toHaveBeenCalledWith('user-2', 'system-managed-id')
})
})

describe('migration parity: admin-role event path (legacy hook.adminRole.*)', () => {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[✨ Éloge] Les gardes négatives documentées (« pas d'emitAdminRoleEvent ») transforment un choix de migration en contrat testé — bon filet anti-régression pour le cutover.

const adminRoles: AdminRoleWithDetails[] = [
{ id: 'admin-role-1', name: 'admin', permissions: 0n, position: 0, oidcGroup: '/admin-group', type: 'managed' },
]
const users: UserWithAdminRoles[] = [
{ id: 'user-1', adminRoleIds: ['admin-role-1'] },
]

it('syncs admin-role OIDC groups via cron reconcile ONLY (no event path exists)', async () => {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 risk: Le test de « parité » n'assert que getOrCreateGroupByPath('/admin-group') : le user avec adminRoleIds=[id] doit aussi être ajouté au groupe. Assert addUserToGroup(userId, 'kc-parity-group-id'), sinon la parité membership n'est pas prouvée.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 nit: Doublon de « should sync admin role groups » (L82) : même flux handleCron, seuls les ids changent. La valeur ajoutée est le nom, pas la couverture — fusionner dans le test existant ou supprimer.

datastore.getAllProjects.mockResolvedValue([])
datastore.getAllAdminRoles.mockResolvedValue(adminRoles)
datastore.getAllUsersWithAdminRoleIds.mockResolvedValue(users)

const adminGroup = makeGroupRepresentation({ id: 'kc-parity-group-id', name: 'admin', path: '/console/parity-admin' })
keycloak.getOrCreateGroupByPath.mockResolvedValue(adminGroup)
keycloak.getGroupMembers.mockResolvedValue([])

await service.handleCron()

expect(keycloak.getOrCreateGroupByPath).toHaveBeenCalledWith('/admin-group')
expect(keycloak.addUserToGroup).toHaveBeenCalledWith('user-1', 'kc-parity-group-id')
})

it('exposes NO adminRole emit entrypoint on AppEventsService (cutover guard)', async () => {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 nit: La garde emitAdminRoleEvent vit dans le spec keycloak avec un import dynamique + getOwnPropertyNames, alors que la garde zone identique vit dans app-events.service.spec.ts (L187) avec 'emitZoneEvent' in service. Déplacer la garde adminRole à côté de la garde zone et uniformiser la technique.

const { AppEventsService } = await import('../events/app-events.service')
expect(Object.getOwnPropertyNames(AppEventsService.prototype))
.not.toContain('emitAdminRoleEvent')
})
})
})
Loading