Repository navigation
Skip comments when looking for the next form to align - #176
Merged
Merged
Conversation
A comment at the end of a line takes its newline, and align-region steps back to the end of the line after a match on the next one, so the search found the comment again and moved over it as a form. Before a blank line that put the match before the previous one, which made align-region signal an invalid search bound, and before a binding with metadata it measured the metadata alone as the binding's name.
bbatsov
force-pushed
the
fix-align-blank-line-after-comment
branch
from
November 7, 2026 09:23
ab9b48c to
88b6db3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment at the end of a line takes its newline, so after
align-regionstepped back to the end of a line the search found the comment again and treated it as a form. Before a blank line, as in{:a 1 ;; cfollowed by a blank line and the closing brace, that signalled "Invalid search bound (wrong side of point)", and before a binding with metadata it aligned to the metadata alone. clojure-mode skips the comment there, and the output now matches it.