Repository navigation
Conversation
The ns edits only looked at the plain libspecs of the first :require clause, so with [c.d :as d] behind #?(:clj ...), or in a second :require clause, adding a require as d put a second :as d into the form, which then didn't compile. Every libspec now counts when checking whether an alias or a refer is taken, reader conditionals (#?@ included) and later :require clauses too.
cider-ns-add-missing rejected ::config/aero as a keyword, though magic requires already handle that alias. It now goes by the same namespaces they do, asks which when there's more than one, and adds the require. A keyword that needs no require still gets an error.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cider-ns-add-missingrefused auto-resolved keywords, though magic requires already resolve their aliases, so it now goes by the same namespaces and adds the require. The ns edits also missed aliases and refers taken in reader conditionals (#?,#?@) and in a second:requireclause, and added a clashing:asthat broke the ns form.Fixes #4222