Repository navigation
Fix the babashka and eldoc regressions ahead of 2.1 - #4227
Merged
Merged
Conversation
The async eldoc path handed no-eldoc replies to the info builder, which turned the missing name into ".nil" and kept eldoc from falling back to the enclosing function's arglists.
Babashka 1.13.221 started reporting a Clojure version in describe, and every runtime check looked for Clojure first, so a bb REPL got the cider-nrepl checks and setup meant for JVM Clojure.
2.1 shouldn't ship on an alpha, and the final releases bring the shadow-cljs inspector and test fixes plus the reload fixes in 0.64.1. The changelog now carries a single entry for the whole bump.
nREPL reads an empty list on a ?-key as false, so callers that relied on nil going out as () now get the server default instead.
bbatsov
force-pushed
the
release-2.1-prep
branch
from
November 9, 2026 18:29
9c1432e to
79fc0e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Babashka 1.13.221+ reports a Clojure version in
describe, and every runtime check looked for Clojure first, so a bb REPL got the JVM setup and errored oncider/init-debugger. Async eldoc never checkedno-eldocand showed.nil: ()for unknown symbols.Also moves the injected cider-nrepl off the alpha to 0.64.1 (one changelog entry instead of five) and fills in the compatibility matrix up to 2.1.
Fixes #4209
Fixes #4224