Fix internal authority in HTTP handler transactions - #5978
Draft
cloutiertyler wants to merge 2 commits into
Draft
cloutiertyler wants to merge 2 commits into
cloutiertyler wants to merge 2 commits into
Conversation
cloutiertyler
requested review from
JasonAtClockwork,
coolreader18 and
lisandroct
September 24, 2026 14:57
JasonAtClockwork
approved these changes
Sep 24, 2026
JasonAtClockwork
left a comment
JasonAtClockwork
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the C++ side
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
HTTP handler transaction contexts in Rust, C#, and C++ no longer report internal authority. Reusing an
is_internal()-gated authorization helper inside a handler could previously grant that branch to anonymous HTTP requests. TypeScript already reports external authority.The Rust behavior originated in #4636 and persisted through #5323. Existing modules must be rebuilt and republished to receive the fix; upgrading the host alone is insufficient. Split from #5892.
API and ABI breaking changes
This changes the behavior of
is_internal()for Rust, C#, and C++ in HTTP handlers. HTTP handlers are unstable in those languages, but nevertheless this is a potentially codebreaking change.Rollback safety impact
n/a
Expected complexity level and risk
1/5. Changes only handler authentication construction in the module libraries.
Testing
All three handler regressions fail against the original implementations and pass with the fix. Rust (4 tests) and native C++ (5 tests) cover both transaction APIs and commit retries; C# (9 tests, .NET 8 target) covers the shared handler factory and refresh path. Enables the existing C# test assembly to access runtime internals. No workflow changes.