Bump rust toolchain to 1.96.1 - #5924
Merged
Merged
Conversation
coolreader18
requested review from
bfops,
cloutiertyler,
jdetter and
rekhoff
as code owners
September 10, 2026 17:40
coolreader18
force-pushed
the
noa/upd-rust-1.98
branch
4 times, most recently
from
September 16, 2026 21:30
db99da4 to
31d4f62
Compare
coolreader18
added this pull request to stack #5954
September 16, 2026 21:33
coolreader18
force-pushed
the
noa/upd-rust-1.98
branch
2 times, most recently
from
September 18, 2026 15:30
f3a724d to
caaf134
Compare
coolreader18
changed the title
coolreader18
force-pushed
the
noa/upd-rust-1.98
branch
from
September 18, 2026 15:34
caaf134 to
c39aac7
Compare
jdetter
approved these changes
Sep 18, 2026
jdetter
left a comment
jdetter
left a comment
Contributor
There was a problem hiding this comment.
We discussed this during standup. We decided to do a lower-risk change here which is to instead of taking literally the latest version we're using a version from ~2 minor releases ago.
I have no objections from the devops side so I'm good to approve this. Tyler gave his verbal approval during standup today as long as we're using a version from at least 2 minor revisions ago. I verified that at the time of writing this PR the latest version available is 1.98.0 and we're upgrading to 1.96.0 which fits that criteria.
Thanks @coolreader18 👍
coolreader18
force-pushed
the
noa/upd-rust-1.98
branch
4 times, most recently
from
September 24, 2026 17:16
d58a226 to
379cd1e
Compare
coolreader18
removed this pull request from stack #5954
September 24, 2026 17:23
coolreader18
added this pull request to stack #5982
September 24, 2026 17:23
cloutiertyler
approved these changes
Sep 24, 2026
Contributor
|
As discussed we want to bump this, but not to latest stable. This LGTM. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 24, 2026
coolreader18
force-pushed
the
noa/upd-rust-1.98
branch
from
September 24, 2026 20:57
379cd1e to
a925167
Compare
coolreader18
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
rust-analyzer was complaining about the toolchain version being too old for it to work properly. This also ups the MSRV; I think I recall that we decided that we generally want to keep that in sync with our toolchain file.
I also wrote a script to keep the various version numbers we have in dockerfiles and such in sync with the rust-toolchain file.
cc @clockworklabs/devops
API and ABI breaking changes
MSRV bump but I don't think we count that.
Rollback safety impact
n/a
Expected complexity level and risk
2
Testing
n/a (or, I'm not sure what this involves)