-
Notifications
You must be signed in to change notification settings - Fork 468
fix(ui): Organization Panel rough in updates #9508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
bdff2d0
feat(ui): add organization profile general panel
austincalvelage 26ad553
feat(ui): add organization profile page shell
austincalvelage 10ea9db
docs(swingset): add organization profile compositions
austincalvelage 6f306af
feat(ui): add organization members collection
austincalvelage 1e3320f
feat(ui): add organization members panel
austincalvelage f94d81e
docs(swingset): add organization members compositions
austincalvelage 1148f5b
feat(ui): add organization security sections
austincalvelage 11e04ee
feat(ui): add organization security panel
austincalvelage a9980f3
docs(swingset): add organization security compositions
austincalvelage d1a03ee
feat(ui): add organization billing sections
austincalvelage de0351d
feat(ui): add organization billing panel
austincalvelage 48aae00
docs(swingset): add organization billing compositions
austincalvelage f3166f2
feat(ui): add organization API keys collection
austincalvelage 32f02cc
feat(ui): add organization API keys panel
austincalvelage c18f12a
docs(swingset): add organization API keys compositions
austincalvelage cb9b59c
docs(ui): clarify profile rough-in follow-ups
austincalvelage 83d7d2b
docs(ui): note API key search follow-up
austincalvelage 7bab24f
docs(ui): mark remaining profile rough-ins
austincalvelage 9d83d15
fix(electron,ui): Don't run passkey autofill as a modal prompt (#9500)
jeremy-clerk 2ac2944
test(expo): wait for native bootstrap before asserting 401 recovery (…
wobsoriano 6bba061
fix(expo-google-signin): resolve presenting view controller from the …
wobsoriano b375812
ci(repo): Version packages (#9495)
clerk-cookie 64a3c6a
fix(ui): correct organization delete label
austincalvelage 1eaae27
fix(ui): align profile page data flow
austincalvelage 9644b07
refactor(ui): share organization profile page tabs
austincalvelage 62abcfa
Merge branch 'main' into austin/org-profile-rough-in
austincalvelage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import * as Stories from './organization-page.stories'; | ||
|
|
||
| # OrganizationPage | ||
|
|
||
| The Organization profile shell. It owns the organization navigation and composes independent panels. | ||
|
|
||
| <Story | ||
| name='Default' | ||
| storyModule={Stories} | ||
| composition={[ | ||
| { | ||
| name: 'General panel', | ||
| href: '/organization-profile/organization-profile-general-panel', | ||
| layer: 'Organization Profile', | ||
| }, | ||
| { | ||
| name: 'Members panel', | ||
| href: '/organization-profile/organization-profile-members-panel', | ||
| layer: 'Organization Profile', | ||
| }, | ||
| { | ||
| name: 'Security panel', | ||
| href: '/organization-profile/organization-profile-security-panel', | ||
| layer: 'Organization Profile', | ||
| }, | ||
| { | ||
| name: 'Billing panel', | ||
| href: '/organization-profile/organization-profile-billing-panel', | ||
| layer: 'Organization Profile', | ||
| }, | ||
| { | ||
| name: 'API Keys panel', | ||
| href: '/organization-profile/organization-profile-api-keys-panel', | ||
| layer: 'Organization Profile', | ||
| }, | ||
| ]} | ||
| /> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the required documentation sections.
These pages only render stories. Add
Playground,Props, andUsagesections in that order. Include a Default column for documented props.packages/swingset/src/stories/organization-page.mdx#L3-L37: Add the three required sections around the existing composition.packages/swingset/src/stories/organization-profile-api-keys-panel.mdx#L3-L17: Add the three required sections around the existing composition.packages/swingset/src/stories/organization-profile-api-keys-section.mdx#L3-L15: Add the three required sections around the Default and Empty stories.packages/swingset/src/stories/organization-profile-billing-panel.mdx#L3-L27: Add the three required sections around the existing composition.packages/swingset/src/stories/organization-profile-danger-section.mdx#L3-L10: Add the three required sections around the existing story.packages/swingset/src/stories/organization-profile-details-section.mdx#L3-L10: Add the three required sections around the existing story.As per coding guidelines: “Playground / Props / Usage are mandatory and always in this order.”
🧰 Tools
🪛 LanguageTool
[grammar] ~3-~3: Ensure spelling is correct
Context: ... from './organization-page.stories'; # OrganizationPage The Organization profile shell. It owns ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
📍 Affects 6 files
packages/swingset/src/stories/organization-page.mdx#L3-L37(this comment)packages/swingset/src/stories/organization-profile-api-keys-panel.mdx#L3-L17packages/swingset/src/stories/organization-profile-api-keys-section.mdx#L3-L15packages/swingset/src/stories/organization-profile-billing-panel.mdx#L3-L27packages/swingset/src/stories/organization-profile-danger-section.mdx#L3-L10packages/swingset/src/stories/organization-profile-details-section.mdx#L3-L10🤖 Prompt for AI Agents
Source: Coding guidelines