Skip to content

fix(ui): Actions border radius consistency #9146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcarpenter merged 2 commits into from
Jul 13, 2026
+7 −80
Merged

fix(ui): Actions border radius consistency #9146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbab7a2
fix(ui): Actions border radius consistency
alexcarpenter Jul 13, 2026
7765c98
add changeset
alexcarpenter Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-cooks-brush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/ui': patch
---

Fix small actions button border radius to ensure consistency.
82 changes: 2 additions & 80 deletions packages/ui/src/elements/Actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';

import type { LocalizationKey } from '../customizables';
import { Button, Col, descriptors, Flex, Icon, SimpleButton, Spinner, useLocalizations } from '../customizables';
import { Button, Col, descriptors, Flex, Icon, Spinner, useLocalizations } from '../customizables';
import type { ElementDescriptor, ElementId } from '../customizables/elementDescriptors';
import { useCardState } from '../elements/contexts';
import { useLoadingStatus } from '../hooks';
Expand Down Expand Up @@ -43,84 +43,6 @@ type ActionProps = Omit<PropsOfComponent<typeof Button>, 'label'> & {
spinnerSize?: PropsOfComponent<typeof Spinner>['size'];
};

export const ExtraSmallAction = (props: Omit<ActionProps, 'label'>) => {

@alexcarpenter alexcarpenter Jul 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing unused component

const card = useCardState();
const status = useLoadingStatus();
const {
icon,
onClick: onClickProp,
iconElementDescriptor,
sx,
iconElementId,
iconSx,
iconBoxElementDescriptor,
iconBoxElementId,
iconBoxSx,
trailing,
spinnerSize,
...rest
} = props;

const onClick: React.MouseEventHandler<HTMLButtonElement> = async e => {
card.setLoading();
status.setLoading();
try {
await onClickProp?.(e);
} finally {
card.setIdle();
status.setIdle();
}
};

return (
<SimpleButton
size='xs'
variant='outline'
hoverAsFocus
sx={[
t => ({
borderRadius: t.radii.$lg,
gap: 0,
justifyContent: 'center',
padding: t.space.$1,
}),
sx,
]}
isDisabled={card.isLoading}
onClick={onClick}
{...rest}
>
<Flex
elementDescriptor={iconBoxElementDescriptor}
elementId={iconBoxElementId}
justify='center'
as='span'
>
{status.isLoading ? (
<Spinner
size={spinnerSize || 'xs'}
elementDescriptor={descriptors.spinner}
/>
) : (
<Icon
elementDescriptor={iconElementDescriptor}
elementId={iconElementId}
icon={icon}
sx={[
theme => ({
width: theme.sizes.$4,
height: theme.sizes.$4,
}),
iconSx,
]}
/>
)}
</Flex>
{trailing}
</SimpleButton>
);
};

export const SmallAction = (props: ActionProps) => {
const { sx, iconBoxSx, iconSx, ...rest } = props;
return (
Expand All @@ -130,7 +52,7 @@ export const SmallAction = (props: ActionProps) => {
textVariant='buttonSmall'
sx={[
t => ({
borderRadius: t.radii.$lg,
borderRadius: t.radii.$md,
gap: t.space.$0x5,
justifyContent: 'center',
flex: '1 1 0',
Expand Down
Loading