Skip to content

fix(mosaic): match menu item idle and hover colors to UserButton rows - #10281

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/mosaic-menu-item-color
Oct 16, 2026
Merged

alexcarpenter merged 2 commits into
mainfrom
carp/mosaic-menu-item-color

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Description

Menu.Item now uses --cl-color-foreground-secondary at rest and --cl-color-foreground on hover and keyboard highlight, matching the UserButton rows. Icons inherit the item color via currentColor. Negative items keep their negative color.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 16, 2026 6:42pm UTC
swingset Ready Ready Preview Oct 16, 2026 6:42pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7a29af3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/mosaic Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: ba40ff8a-573c-419c-b789-1f9bf95533d0
📥 Commits

Reviewing files that changed from the base of the PR and between aac8774 and 7a29af3.

📒 Files selected for processing: 2
  • .changeset/mosaic-menu-item-color.md
  • packages/mosaic/src/components/menu/menu.styles.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

Menu item text now uses the secondary foreground color by default. It uses the foreground color when active or hovered on hover-capable devices. A patch changeset records the update.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~7 minutes

Suggested reviewers: dstaley

Merge Risk: ⚪ Minimal · up to 7a29a

No actionable merge-blocking risk is established by the reviewed changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary change: matching menu item idle and hover colors to UserButton rows.
Description check Passed The description directly explains the color, hover, keyboard highlight, icon inheritance, and negative-item behavior changed by the pull request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10281

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10281

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10281

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10281

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10281

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10281

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10281

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10281

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10281

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10281

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10281

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10281

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10281

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10281

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10281

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10281

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10281

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10281

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10281

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10281

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10281

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10281

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10281

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10281

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10281

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10281

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10281

commit: 7a29af3

@alexcarpenter
alexcarpenter enabled auto-merge (squash) October 16, 2026 18:50
@alexcarpenter
alexcarpenter merged commit 1486b17 into main Oct 16, 2026
54 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-menu-item-color branch October 16, 2026 18:52

This branch was successfully deployed

2 active deployments
Preview – swingset — 7a29af3f Deployed Oct 16, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 7a29af3f Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants