Repository navigation
Seek from the lock screen, and show the cover of the song playing here - #48
Merged
Merged
Conversation
Contributor
Author
|
The No fix for Generated by Claude Code |
ScreenshotsFrom run 37544971558, against a real Clementine. Left: main. Right: this pull request, light and dark.
|
hatstand
marked this pull request as ready for review
October 6, 2026 23:09
hatstand
enabled auto-merge (rebase)
October 6, 2026 23:09
While Clementine plays on the phone, Now Playing had no position bar to drag, though Android's notification seeks. And it took the cover from Clementine's current song whatever was playing here, so after a change of song it could show the previous song's cover, until the next status update or, when paused, until something else changed. The cover is now only shown once Clementine's song is the one playing here, refreshed when the song arrives, and decoded once rather than on every update. Release-note: While Clementine plays on your iPhone, you can seek from the lock screen, and it no longer shows the previous song's cover after a change of song. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DihgxevQ7a59sF9RFc4Wby
hatstand
force-pushed
the
claude/project-thread-65hya0
branch
from
October 6, 2026 23:09
5bf83bf to
0f593f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by John · project thread
Before: while Clementine plays on the iPhone, Now Playing on the lock screen and in Control Center has no position bar to drag, although Android's notification can seek. Right after a song change it can show the previous song's cover. That lasts until the next status update, or longer while paused.
After: you can drag the position bar for songs that have a length, and Clementine seeks. The cover only appears once Clementine's current song is the one playing on the phone, and it refreshes as soon as that song arrives.
How:
NowPlayingregisterschangePlaybackPositionCommand, sending Clementine a seek, and enables it only when the item has a length. The cover comes fromsession.songonly when its URL matches the render item's song. The cover is cached so it isn't decoded again on every once-a-second update.AppModelalso refreshes Now Playing onCURRENT_METAINFO.design/DESIGN.mdis updated to match.This was not built locally because the session had no Xcode, so CI is the first build.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DihgxevQ7a59sF9RFc4Wby
Generated by Claude Code