Hi! 馃憢
Firstly, thanks for your work on this project! 馃檪
Today I used patch-package to patch classcharts-api@2.12.3 for the project I'm working on.
The auth wasn't working due to the cookie handling.
Here is the diff that solved my problem:
diff --git a/node_modules/classcharts-api/esm/src/core/parentClient.js b/node_modules/classcharts-api/esm/src/core/parentClient.js
index 2aa47e0..4fff4c0 100644
--- a/node_modules/classcharts-api/esm/src/core/parentClient.js
+++ b/node_modules/classcharts-api/esm/src/core/parentClient.js
@@ -71,7 +71,9 @@ export class ParentClient extends BaseClient {
throw new Error("Unauthenticated: ClassCharts didn't return authentication cookies");
}
const cookies = String(response.headers.get("set-cookie"));
- this.authCookies = cookies.split(";");
+ this.authCookies = response.headers
+ .getSetCookie()
+ .map(cookie => cookie.split(";")[0]);
const sessionCookies = parseCookies(cookies);
const sessionID = JSON.parse(String(sessionCookies.parent_session_credentials));
this.sessionId = sessionID.session_id;
diff --git a/node_modules/classcharts-api/script/src/core/parentClient.js b/node_modules/classcharts-api/script/src/core/parentClient.js
index 9201c6d..54f9b4d 100644
--- a/node_modules/classcharts-api/script/src/core/parentClient.js
+++ b/node_modules/classcharts-api/script/src/core/parentClient.js
@@ -74,7 +74,9 @@ class ParentClient extends baseClient_js_1.BaseClient {
throw new Error("Unauthenticated: ClassCharts didn't return authentication cookies");
}
const cookies = String(response.headers.get("set-cookie"));
- this.authCookies = cookies.split(";");
+ this.authCookies = response.headers
+ .getSetCookie()
+ .map(cookie => cookie.split(";")[0]);
const sessionCookies = (0, utils_js_1.parseCookies)(cookies);
const sessionID = JSON.parse(String(sessionCookies.parent_session_credentials));
this.sessionId = sessionID.session_id;
This issue body was partially generated by patch-package.
Hi! 馃憢
Firstly, thanks for your work on this project! 馃檪
Today I used patch-package to patch
classcharts-api@2.12.3for the project I'm working on.The auth wasn't working due to the cookie handling.
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.