Fix nightly PostgreSQL exclusion filtering - #426
Closed
ibrahim halatci (ihalatci) wants to merge 2 commits into
Closed
Fix nightly PostgreSQL exclusion filtering#426ibrahim halatci (ihalatci) wants to merge 2 commits into
ibrahim halatci (ihalatci) wants to merge 2 commits into
Conversation
get_postgres_versions() built the excluded nightly list by iterating release_versions instead of nightly_versions, so any entry under `exclude.nightly` in pg_exclude.yml silently replaced the nightly postgres versions with the release ones. The bug is currently dormant because `exclude.nightly` is empty, but it makes the nightly exclusion feature unusable: adding a single nightly exclusion switches nightly builds over to the release matrix. With citus main at 15.0devel this would have produced PG15/PG16 nightlies, neither of which main supports any more. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bb18c8e4-f4c5-43b7-92cf-30d6b03deb87
The Oracle Linux fixture excludes PostgreSQL 15 from the nightly matrix, so the corrected filter now leaves only PostgreSQL 14. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Superseded by #423, which merged the same nightly exclusion fix into develop and is included in the stable v0.8.39 tag. Closing rather than resolving the duplicate conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nightly_versionsinstead ofrelease_versionsWhy
The bug is latent while
exclude.nightlyis empty: adding any nightly exclusion currently replaces the nightly matrix with filteredrelease_versions. Filteringnightly_versionspreserves the intended nightly matrix while removing only the excluded PostgreSQL versions.This is required by the companion all-citus matrix change that excludes PostgreSQL 19: citusdata/packaging#1215. Both changes are required, but they can land in either order.