Repository navigation
docs(go): typed JSON walkthrough and accurate EQL reference - #1402
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be96a9e52e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mise run wasm:guest:build:deterministic | ||
| mise run wasm:guest:build:eql:deterministic | ||
| mise run wasm:auth-guest:build | ||
| mise run go:test |
There was a problem hiding this comment.
Build the production guests before invoking the Go test task
On a fresh checkout, this sequence does not produce the production encryption guests required by mise run go:test. In mise.toml, the two deterministic tasks copy their outputs only into encrypt/testdata/, whereas scripts/go-binding-test.sh explicitly requires encrypt/wasm/stack_encrypt_guest.wasm and encrypt/eql/wasm/stack_encrypt_guest_eql.wasm and exits before running tests if either is absent. Add wasm:guest:build and wasm:guest:build:eql alongside the deterministic builds, and update the identical sequence in CONTRIBUTING.md as well.
Useful? React with 👍 / 👎.
cipherstash-agent
left a comment
There was a problem hiding this comment.
Review attestation: /code-review medium followed by company-skills:cross-check-review-findings (cipherstash/skills), run against head be96a9e.
Result: no findings. No critical or blocking issues.
- Verified at head: the stashgen README capability table matches the
Producible: trueset ineql_gen.go(50 of 50), which is what the new drift test asserts. - Verified at head: the example's run instructions load the right guest.
encryptselects the EQL guest whenencrypt/eqlis linked, sowasm:guest:build:eqland the auth guest are sufficient. - Verified at head: the
Between,GtandSubtreereferences in the docs exist in the generated code. - Verified at head: the Go version floor matches
go.mod. - Existing PR feedback: none to cross-check. The only comments are bot status notices (CodeRabbit skipped, changeset-bot, Codex still running).
- Not verified: the example was not run live (needs ZeroKMS credentials and EQL v4 PostgreSQL).
misewas unavailable, so the Go suite was not re-run. CI was still in progress when this ran.
Generated by Claude Code
Summary
JsonSearchand ordered date, timestamp, and numeric types; fix contradictory release notes and add a catalog drift check.Validation
mise run wasm:guest:build,mise run wasm:guest:build:eql,mise run wasm:auth-guest:buildGOCACHE=/private/tmp/go-doc-cache mise run go:testgo generate ./...(clean tree afterward)vitest run scripts/__tests__/go-eql-doc-capabilities.test.mjsThe example compiled as part of the Go suite. A live run of the example needs ZeroKMS credentials and a PostgreSQL database with EQL v4 installed.