fix(deps): patch sharp to 0.35.5 by tobyhede · Pull Request #1151 · cipherstash/stack

tobyhede · 2026-10-12T01:06:33Z

Summary

Raises the existing sharp pnpm override in pnpm-workspace.yaml from 0.35.4 to 0.35.5 to fix GHSA-wq5f-xc86-pv6w / CVE-2026-96889 (Dependabot alert #246). The bundled librsvg has a memory-safety bug that may allow remote code execution. sharp is still reached only as an optional dependency of next (image optimization).

Override: 'sharp@<0.35.4': '0.35.4' -> 'sharp@<0.35.5': '0.35.5'. The selector ceiling moves with the pin, as in the earlier sharp bumps.
Lockfile: only sharp and its @img/* platform binaries change (@img/sharp-* 0.35.4 -> 0.35.5, @img/sharp-libvips-* 1.3.3 -> 1.3.4). No other packages change.
0.35.5 was published 2026-09-27, outside the 7-day minimumReleaseAge window.

Verification

pnpm install --frozen-lockfile succeeds.
pnpm why sharp -r reports a single version, sharp@0.35.5 (via next@15.5.24).
No sharp < 0.35.5 or libvips 1.3.3 entries remain in pnpm-lock.yaml.
The native module loads (require('sharp').versions: sharp 0.35.5, vips 8.18.7, rsvg 2.63.2).
Integrity hashes for sharp and a sample of the @img/* binaries match the npm registry.

Note: the lockfile was regenerated with --config.minimum-release-age=0 for this run only. Without it, changing the override forces a full re-resolve, and the cooldown then downgrades two versions that are already on main (express-rate-limit 8.7.1 -> 8.7.0, acorn 8.19.0 -> 8.18.0). The repo's minimumReleaseAge setting is unchanged.

Summary by CodeRabbit

Chores
- Updated internal configuration. No user-facing changes are included in this update.

Raise the existing sharp override to 0.35.5 for GHSA-wq5f-xc86-pv6w / CVE-2026-96889 (Dependabot alert #246): a memory-safety bug in the bundled librsvg, with possible remote code execution, fixed in sharp >=0.35.5. The selector ceiling moves with the pin so 0.35.4 cannot resolve. sharp is still reached only as an optional dependency of next. The lockfile change is limited to sharp and its @img/* platform binaries (@img/sharp-* 0.35.5, @img/sharp-libvips-* 1.3.4). 0.35.5 was published 2026-09-27, outside the 7-day minimumReleaseAge window.

changeset-bot · 2026-10-12T01:06:37Z

⚠️ No Changeset found

Latest commit: 7c653ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chatgpt-codex-connector · 2026-10-12T01:06:41Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-12T01:08:13.178374Z	`7c653ec`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-12T01:07:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: 07772b0a-6da8-4545-b621-00b190571d3f

📥 Commits

Reviewing files that changed from the base of the PR and between 1e9fba3 and 7c653ec.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

pnpm-workspace.yaml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

Walkthrough

The pnpm workspace sharp override now matches versions below 0.35.5 and pins them to 0.35.5.

Changes

Sharp Override

Layer / File(s)	Summary
Update sharp override `pnpm-workspace.yaml`	The override selector changes from below 0.35.4 to below 0.35.5. The pin changes from 0.35.4 to 0.35.5.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: auxesis

Merge Risk: ⚪ Minimal · up to 7c653

The override and lockfile select sharp 0.35.5 and its corresponding binaries. No merge-blocking risk is established.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the dependency fix and the target sharp version, which matches the main change.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

freshtonic

Review of 7c653ec. I found no blocking defect.

What I checked

Advisory. GHSA-wq5f-xc86-pv6w names < 0.35.5, first patched 0.35.5. The selector at pnpm-workspace.yaml:163 ('sharp@<0.35.5': '0.35.5') matches the advisory exactly.
Coverage. The PR lockfile has no sharp@0.35.4 and no libvips 1.3.3 entry. The only consumer snapshot is sharp: 0.35.5.
Lockfile scope. The description says that you regenerated with minimum-release-age=0. I compared the lockfile diff: every changed line is a sharp, @img/sharp-* or libvips entry. No other package moved, so the cooldown bypass did not pull in a new version of anything else.
Changeset. Not needed. sharp comes in only as an optional dependency of next. pnpm overrides do not ship to consumers.
CI. 23 checks pass and 11 skip (path filters). No failures.

Overlap with #1197

#1197 has a text conflict with this PR in pnpm-lock.yaml. GitHub blocks that merge, so it is safe. But #1197 does not fix this advisory by itself: it keeps the old override sharp@<0.35.4: 0.35.4 (its pnpm-lock.yaml:46), and sharp stays at 0.35.4 even with next 15.5.27. Merge this PR first. Then let Dependabot recreate #1197. Do not resolve the conflict by hand in favour of #1197's lockfile.

tobyhede requested a review from a team as a code owner October 12, 2026 01:06

yujiyokoo approved these changes Oct 13, 2026

View reviewed changes

freshtonic reviewed Oct 14, 2026

View reviewed changes

This was referenced Oct 14, 2026

chore(deps): bump the production-minor-patch group across 1 directory with 16 updates #1197

Closed

chore(deps): bump next from 15.5.24 to 15.5.27 #1135

Merged

tobyhede merged commit 141054f into main Oct 14, 2026
34 checks passed

tobyhede deleted the fix/cip-4888-sharp branch October 14, 2026 22:26

freshtonic mentioned this pull request Oct 15, 2026

Version Packages #1054

Open

Navigation Menu

Repository navigation

fix(deps): patch sharp to 0.35.5 - #1151

fix(deps): patch sharp to 0.35.5#1151
tobyhede merged 1 commit into
mainfrom
fix/cip-4888-sharp

tobyhede commented Oct 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 12, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

freshtonic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tobyhede commented Oct 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 12, 2026

⚠️ No Changeset found

Uh oh!

chatgpt-codex-connector Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

freshtonic left a comment

Choose a reason for hiding this comment

What I checked

Overlap with #1197

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tobyhede commented Oct 12, 2026 •

edited by coderabbitai Bot

Loading

chatgpt-codex-connector Bot commented Oct 12, 2026 •

edited

Loading

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading