Fix Break Handler V2 pause break completion - #1858
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe break handler version changes from 2.0.6 to 2.0.7. The script guard now continues processing selected break states while scripts are paused. Merge Risk: ⚪ Minimal · up to Break handling can now complete and reschedule paused breaks while preserving normal waiting and unpaused-script guard behavior. No concrete current-head merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Why
No-logout breaks call
Microbot.pauseAllScripts.set(true)while the Break Handler still needs to tick untilbreakEndTime. The next scheduler tick can hitsuper.run() == false, return early, and leave the break stuck in the requested/paused state instead of completing and rescheduling timers.Testing
./gradlew.bat :client:compileJava :client:compileTestJava --no-daemon --console=plain./gradlew.bat :client:test --tests "net.runelite.client.plugins.microbot.breakhandler.breakhandlerv2.BreakHandlerV2DeferralTest" --no-daemon --console=plain(build successful;:client:testis skipped by the current Gradle configuration after compiling test classes)