Skip to content

fix(questhelper): allow local Misthalin item pickups - #1854

Closed
itsBOTzilla wants to merge 1 commit into
chsami:mainfrom
itsBOTzilla:fix/misthalin-local-item-pickups
Closed

fix(questhelper): allow local Misthalin item pickups#1854
itsBOTzilla wants to merge 1 commit into
chsami:mainfrom
itsBOTzilla:fix/misthalin-local-item-pickups

Conversation

@itsBOTzilla

@itsBOTzilla itsBOTzilla commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Misthalin Mystery's bucket and table-knife pickup steps require the very items they provide. With automatic missing-item acquisition enabled, the quest runner attempts banking before executing the local pickup, causing repeated bank attempts when no bank route is available from the island.

Remove those two pickup prerequisites while retaining the bucket and knife requirements on the steps that use them. Bump Quest Helper to 1.0.1 and add four regression tests covering both pickups and the retained tool requirements.

Validation:

  • Four Misthalin Mystery regression tests on the upstream main base.
  • All 28 Quest Helper tests passed in the original integration checkout.
  • git diff --check passed; code review found no issues.
  • Live in-game pickup behavior has not been verified.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 88a298d0-9af0-42fa-8191-9223165290cc

📥 Commits

Reviewing files that changed from the base of the PR and between aebc5f7 and 8b8ee22.

📒 Files selected for processing (3)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/questhelper/QuestHelperPlugin.java
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/questhelper/helpers/quests/misthalinmystery/MisthalinMystery.java
  • runelite-client/src/test/java/net/runelite/client/plugins/microbot/questhelper/helpers/quests/misthalinmystery/MisthalinMysteryRequirementsTest.java

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The Quest Helper plugin descriptor now declares version 1.0.1. Misthalin Mystery pickup steps no longer require the bucket or knife items they provide. Later barrel and cutting steps retain their item requirements. A new test verifies these requirement assignments.

Merge Risk: ⚪ Minimal · up to 8b8ee

Quest Helper now collects the Misthalin Mystery bucket and knife locally when absent, while later quest actions still require those tools. The version update and requirement behavior are covered without an identified current merge risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: allowing local Misthalin Mystery item pickups without triggering banking attempts.
Description check ✅ Passed The description accurately explains the pickup prerequisite fix, retained tool requirements, version bump, regression tests, and validation results.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@itsBOTzilla
itsBOTzilla changed the base branch from development to main September 4, 2026 20:06
@itsBOTzilla
itsBOTzilla force-pushed the fix/misthalin-local-item-pickups branch from 8b8ee22 to ad23f63 Compare September 4, 2026 20:07
@itsBOTzilla itsBOTzilla closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant