refactor(link-wizard): give the queue a module - #446
Open
chiptus wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new queue hook currently reports position: 1 when the queue is empty (inconsistent state), and the new tests couple to useLinkWizardSkipped’s localStorage schema instead of its public API.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refactors the Link Wizard’s “queue navigation” into a dedicated useLinkWizardQueue hook, moving selection, stage filtering, and skip/save-then-advance logic out of LinkWizard.tsx and tightening the UI wiring.
Changes:
- Added
useLinkWizardQueuehook to own filtered queue state, current selection, and navigation actions. - Updated
LinkWizard.tsxto delegate queue behavior to the new hook and simplify the page component. - Updated
LinkWizardQueue.tsxto own the mobile “View all” preview toggle locally and removed related props; added hook tests for queue behavior.
File summaries
| File | Description |
|---|---|
| src/pages/admin/festivals/LinkWizard/useLinkWizardQueue.ts | New queue hook centralizing filtering + navigation and exposing a small semantic interface. |
| src/pages/admin/festivals/LinkWizard/useLinkWizardQueue.test.ts | New hook tests covering filtering, selection, prev/skip/save behavior, and post-filter consistency. |
| src/pages/admin/festivals/LinkWizard/LinkWizardQueue.tsx | Moves mobile preview “View all” state into the queue UI component and trims prop surface. |
| src/pages/admin/festivals/LinkWizard/LinkWizard.tsx | Replaces ad-hoc queue/index math with useLinkWizardQueue and wires actions through to the UI. |
Review details
Suppressed comments (1)
src/pages/admin/festivals/LinkWizard/useLinkWizardQueue.test.ts:142
- This test asserts save persistence by reading
localStorageand relying on the internal storage schema ofuseLinkWizardSkipped(stored[EDITION_ID].records[...]). That couples the test to storage internals instead of the hook’s public API.
const stored = JSON.parse(localStorage.getItem("link-wizard-skipped")!);
expect(stored[EDITION_ID].records["1"].status).toBe("saved");
});
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Playwright test results
Details
|
Deepen useLinkWizardQueue to own stage filtering, position, and skip/save-then-advance behavior, replacing the ad-hoc state and index math previously spread across LinkWizard.tsx. useLinkWizardSkipped stays a separate module, passed in as a dependency to keep a single localStorage-backed instance shared with the skipped/saved popover. Closes #445 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
chiptus
force-pushed
the
refactor/link-wizard-queue-module
branch
from
August 28, 2026 08:48
1f59dde to
1a25a25
Compare
…storage schema Report position 0 (not 1) when the queue is empty, matching total: 0 and an undefined currentItem. Assert skip/save persistence through useLinkWizardSkipped's public API instead of parsing localStorage directly, per Copilot review on #446. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepens the Link Wizard's queue navigation into
useLinkWizardQueue, replacing the ad-hoc state and index math spread acrossLinkWizard.tsx.useLinkWizardSkippedstays a separate module, passed in as a dependency so the popover and queue share one localStorage-backed instance.Closes #445
Verification