feat: add frame specific spaces - #21
Draft
AlAl45643 wants to merge 5 commits into
Draft
Conversation
Make space-tree frame specific by replacing space-tree variables with --get and --set functions. Replace any calls to these variables with the --get and --set functions.
Create #'space-tree-init-frames to hook #'space-tree-init to 'after-make-frame-functions unless it is already in 'after-make-frame-functions. Change signature and function calls of any functions called by #'space-tree--create-space-at, and the functions they call, to pass frame parameter to our #'space-tree--get functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add frame specific spaces to allow each frame to have its own space tree instead of mirroring spaces for all frames which causes confusing behavior. This is useful for multi-monitor setups where a frame is created for each monitor.
Testing
I didn't fix any linting issues that I didn't introduce to the code.
eask test ert test/space-tree-test.el (all tests passed) (tests were modified with changes)
eask lint package (no issues found)
eask lint checkdoc
space-tree.elwith checkdoc (0.6.2)space-tree.el:221: Probably "runs" should be imperative "run"
space-tree.el:338: Probably "starts" should be imperative "start"
eask lint elisp-lint
space-tree.elwith elisp-lint (20220419.252)/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:16:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:17:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:18:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:19:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:20:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:23:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:26:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:27:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:28:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:29:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:30:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:31:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:82:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:101:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:221:0 (checkdoc) Probably "runs" should be imperative "run"
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:221:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:252:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:338:0 (checkdoc) Probably "starts" should be imperative "start"
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:472:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:496:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:509:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:553:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:719:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:727:0 (fill-column) line length 70 exceeded
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:748:0 (indent) ! "Switch to top-level space %d." 9
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:749:0 (indent) ! (list n))
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:752:0 (indent) ! "Switch to second-level space %d under the current top-level." 5
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:753:0 (indent) ! (list (nth 0 (space-tree--get-current-address)) n))
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:756:0 (indent) ! "Switch to third-level space %d under the current path." 5
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:757:0 (indent) ! (list (nth 0 (space-tree--get-current-address))
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:758:0 (indent) ! (nth 1 (space-tree--get-current-address)) n))
/home/work/.emacs.d/elpaca/sources/space-tree/space-tree.el:758:0 (indent-character) spaces instead of tabs
eask lint relint (no issues found)
CI matrix (Ubuntu + Windows × Emacs 28.2, 29.4, 30.2, snapshot)