turning off sonar scans and irfan's previous quality dashboard scans … - #61
Open
brianLoomis wants to merge 1 commit into
Open
turning off sonar scans and irfan's previous quality dashboard scans …#61brianLoomis wants to merge 1 commit into
brianLoomis wants to merge 1 commit into
Conversation
…(replaced with disabled notice) commented out logic in case we ever need it again
brianLoomis
requested review from
punitmundra
and
a lite review from Copilot
September 8, 2026 01:06
brianLoomis
requested review from
a team and
sean-sype-simmons
as code owners
September 8, 2026 01:06
There was a problem hiding this comment.
🟡 Changes recommended
The newly added disabled-notice job steps are mis-indented in all three workflow files, making the YAML invalid and preventing the workflows from parsing/running.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Disables the SonarQube and “Irfan quality dashboard” reusable workflows by commenting out their previous job logic and replacing it with a minimal job that only emits a “steps disabled” notice when invoked.
Changes:
- Commented out the SonarQube scan job/steps in the public and internal reusable workflows.
- Commented out the quality dashboard reporting job/steps and replaced execution with a disabled notice.
- Added a
disabled-noticejob to each workflow so workflow invocations still succeed while doing no work.
File summaries
| File | Description |
|---|---|
| .github/workflows/sonarqube-public-repo.yml | Comments out the SonarQube scan workflow steps and adds a disabled-notice job. |
| .github/workflows/sonarqube-internal-repo.yml | Comments out checkout/build/test/scan jobs and adds a disabled-notice job. |
| .github/workflows/irfan-quality-dashboard.yml | Comments out quality dashboard reporting steps and adds a disabled-notice job. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
60
to
+62
| steps: | ||
| #TODO: Test adding Irfan's quality reporting stage inline here after sonar run (https://github.com/Progress-I360/github-action-reporting) | ||
| # PRODUCT_NAME = [Chef360 | Courier | Inspec] | ||
| - name: Run SonarQube report generation | ||
| if: ${{ inputs.report-to-atlassian-dashboard == true && inputs.visibility == 'internal' }} | ||
| uses: Progress-I360/github-action-reporting/sonarqube@main | ||
| with: | ||
| PRODUCT_NAME: ${{ inputs.quality-product-name }} | ||
| SONAR_APP_NAME: ${{ inputs.quality-sonar-app-name }} | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
| - name: Echo disabled notice | ||
| run: echo "All other steps in this workflow have been disabled." |
Comment on lines
82
to
+84
| steps: | ||
| - name: Configure git for private modules | ||
| if: ${{ inputs.visibility == 'internal' }} | ||
| env: | ||
| GOPRIVATE: ${{ inputs.go-private-modules }} # github.com/progress-platform-services/* | ||
| run: git config --global url."https://${{ secrets.GH_TOKEN }}@github.com/".insteadOf "https://github.com/" | ||
| continue-on-error: true | ||
| - name: checkout | ||
| # removed: if: ${{ inputs.perform-build == true && inputs.visibility == 'internal' }} -- this is internal, so always do checkout | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Echo disabled notice | ||
| run: echo "All other steps in this workflow have been disabled." |
Comment on lines
70
to
+72
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Echo disabled notice | ||
| run: echo "All other steps in this workflow have been disabled." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(replaced with disabled notice)
commented out logic in case we ever need it again
Turning off sonar scans and Irfan's quality dashboard (latter we did not use much)