Skip to content

Release 2.2.0 - Top-up instructions and amount allocations - #203

Merged
david-ruiz-cko merged 1 commit into
masterfrom
release/2.2.0
Sep 10, 2026
Merged

Release 2.2.0 - Top-up instructions and amount allocations#203
david-ruiz-cko merged 1 commit into
masterfrom
release/2.2.0

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This release adds support for retrieving top-up instructions for balances sub-accounts, including new models, client methods, and tests. It also improves serialization for new query parameters and updates OAuth scopes.

Balances API enhancements:

  • lib/checkout_sdk/balances/balances_client.rb: Added the retrieve_top_up_instructions method to fetch bank details and payment references for sub-account top-ups. Also added new endpoint constants and improved documentation for retrieve_entity_balances.
  • lib/checkout_sdk/balances/top_up_instructions.rb, lib/checkout_sdk/balances/top_up_bank_details.rb, lib/checkout_sdk/balances/top_up_funding_details.rb: Introduced new model classes to represent top-up instructions, bank details, and funding rails. [1] [2] [3]

Query serialization improvements:

OAuth scope updates:

Testing:

@david-ruiz-cko
david-ruiz-cko requested a review from a team September 10, 2026 09:26
@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown

🟢 Advisory review: Looks good to me

This PR still needs a human approval — wall-e cannot auto-approve it. For what it's worth, I read the diff and found nothing I'd block on.

This PR adds top-up instructions support to the Balances API, including new model classes, client methods, serialization fixes, OAuth scopes, and tests, with a version bump to 2.2.0. The changes look correct and consistent with the stated intent.

What I checked

  • New retrieve_top_up_instructions method follows the existing pattern in balances_client.rb with appropriate endpoint constants and documentation.
  • New model classes (TopUpInstructions, TopUpBankDetails, TopUpFundingDetails) are straightforward data containers consistent with existing SDK model patterns.
  • The json_serializer.rb camelCase mappings for with_currency_account_id and balances_at are a necessary fix for correct query parameter serialization to the API.
  • The new balances:top-up-instructions OAuth scope in oauth_scopes.rb matches what the new endpoint would require.
  • Unit and integration tests cover the new client method, including error response scenarios, providing adequate coverage for the new functionality.
  • Version bump from 2.1.0 to 2.2.0 is consistent with the scope of changes (new features added).

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

@david-ruiz-cko
david-ruiz-cko merged commit f029d8b into master Sep 10, 2026
5 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the release/2.2.0 branch September 10, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants