Skip to content

Release 4.2.0 - Top-up instructions and amount allocations - #236

Merged
david-ruiz-cko merged 1 commit into
mainfrom
release/4.2.0
Sep 10, 2026
Merged

Release 4.2.0 - Top-up instructions and amount allocations#236
david-ruiz-cko merged 1 commit into
mainfrom
release/4.2.0

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This release adds support for retrieving top-up instructions for currency accounts via the balances API, enhances the BalancesQuery filter with improved typing and serialization, and introduces comprehensive tests to ensure correct serialization and response handling. It also adds a new OAuth scope for top-up instructions and updates the test coverage accordingly.

Balances API enhancements:

  • Added a new method retrieve_top_up_instructions to BalancesClient for fetching top-up instructions for a specific currency account, and defined the required endpoint paths. [1] [2]
  • Updated BalancesQuery to use correct types: with_currency_account_id is now a boolean and balances_at is a datetime, with improved docstrings and comments for clarity.

OAuth and authorization:

  • Added the balances:top-up-instructions OAuth scope to OAuthScopes and included it in the default OAuth API test client configuration. [1] [2]

Testing and serialization:

  • Implemented new integration and unit tests for the top-up instructions endpoint, including response-shape tests and serialization checks for BalancesQuery to ensure correct camelCase mapping and ISO date formatting. [1] [2] [3]

Other SDK improvements:

  • Added an amount_allocations field to SubmitPaymentSessionRequest to support allocation of amounts in payment sessions.

@david-ruiz-cko
david-ruiz-cko requested a review from a team September 10, 2026 09:22
@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown

🟢 Advisory review: Looks good to me

This PR still needs a human approval — wall-e cannot auto-approve it. For what it's worth, I read the diff and found nothing I'd block on.

This PR bumps the version to 4.2.0 and adds top-up instructions support to the Balances API, a new OAuth scope, and amount_allocations to payment sessions, with accompanying tests.

What I checked

  • Version bump from 4.1.0 to 4.2.0 is consistent with the PR title claiming a 4.2.0 release.
  • The diff provided is only the version file — the substantive changes (new BalancesClient method, BalancesQuery type fixes, OAuth scope addition, SubmitPaymentSessionRequest field, and tests) are not visible in this diff, so their correctness cannot be verified here.
  • A human reviewer should confirm the full diff is attached and review the API client changes, serialization logic, and test coverage before approving.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

@david-ruiz-cko
david-ruiz-cko merged commit 1b5e1d1 into main Sep 10, 2026
4 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the release/4.2.0 branch September 10, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants