Skip to content

Release 4.0.0 - #231

Merged
armando-rodriguez-cko merged 1 commit into
mainfrom
release/4.0.0
Aug 31, 2026
Merged

Release 4.0.0#231
armando-rodriguez-cko merged 1 commit into
mainfrom
release/4.0.0

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

- The merchant-specific subdomain (environment_subdomain) is now required. Set it, or call the deprecated use_legacy_domain() to keep using the shared checkout.com hosts.
- An invalid subdomain now raises instead of being silently ignored.
- Add optional amount to VoidRequest to support partial voids.
- Add the ISV (SaaS seller) payout schedule fields balance_minimum, carry_forward_enabled and payment_instrument_id.
@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team August 31, 2026 16:03
@agent-wall-e

agent-wall-e Bot commented Aug 31, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Aug 31, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Aug 31, 2026

Copy link
Copy Markdown

🔵 Advisory review: Sound, but needs your judgement

This PR needs a human approval. The code itself reads as correct; whether it should land depends on context I don't have.

This diff only bumps the version string from 3.13.0 to 4.0.0, but the PR description claims four substantive changes (required subdomain, invalid subdomain validation, VoidRequest amount, ISV payout fields). None of those changes are visible in the diff.

For you to decide

  • The diff is almost certainly partial — only properties.py is shown, so the actual feature and breaking-change code cannot be verified against the PR claims.
  • A major version bump (3.x → 4.0.0) implies breaking changes; a human reviewer must confirm the breaking-change behaviour (required subdomain, raised exception on invalid subdomain) is actually implemented and properly documented/communicated.
  • The version bump itself looks mechanically correct for a 4.0.0 release, but correctness of the release as a whole cannot be assessed from this fragment alone.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

@armando-rodriguez-cko
armando-rodriguez-cko merged commit 9f6b01e into main Aug 31, 2026
3 of 4 checks passed
@armando-rodriguez-cko
armando-rodriguez-cko deleted the release/4.0.0 branch August 31, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants