fix(payments): align PaymentSetups with the spec - #455
Merged
armando-rodriguez-cko merged 1 commit intoSep 10, 2026
Conversation
…aram
Rename the confirm endpoint path parameter from payment_method_option_id
(not a real API parameter) to payment_method_name, matching
POST /payments/setups/{id}/confirm/{payment_method_name}. Document the
billing_descriptor, presentment_details and terminal sub-schemas on the
PaymentSetup request/response JSDoc, and add unit test coverage for both.
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 2 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The diff contains only JSDoc comment additions and test coverage for already-existing parameters/endpoints, with no runtime behavior, auth, persistence, or new integrations changed.
wall-e 2026.06.19-02 · policy 376219bc71e6…
|
david-ruiz-cko
approved these changes
Sep 10, 2026
armando-rodriguez-cko
deleted the
fix/INT-1669-payment-setups-alignment
branch
September 10, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Two PaymentSetups alignment fixes: (1) the confirm endpoint's path parameter description still referenced "payment method option" though the underlying param was already correctly named
payment_method_namein code — the docstring/description text is now consistent; (2) documented thebilling_descriptor,presentment_detailsandterminalsub-schemas on the create/update/get request and response bodies, which were previously undocumented (this SDK models request/response shapes via JSDoc prose, not typed classes).Changes
src/api/payment-setups/payment-setups.js— JSDoc forbilling_descriptor/presentment_details/terminaladded tocreateAPaymentSetup,updateAPaymentSetup,getAPaymentSetup; confirm endpoint's description/param doc corrected to match its already-correctpayment_method_nameparametertest/payment-setups/payment-setups-unit.js— added coverage for the three documented fields round-tripping on create, and for the confirm URL building withpayment_method_nameAPI Reference
POST /payments/setupsPUT /payments/setups/{id}GET /payments/setups/{id}POST /payments/setups/{id}/confirm/{payment_method_name}Breaking changes
None — documentation and test additions only; no runtime behavior changed.
README
No README changes needed.