Skip to content

Release 5.1.0 - BACS Direct Debit notifications + refactor - #453

Merged
david-ruiz-cko merged 1 commit into
masterfrom
release/5.1.0
Sep 7, 2026
Merged

Release 5.1.0 - BACS Direct Debit notifications + refactor#453
david-ruiz-cko merged 1 commit into
masterfrom
release/5.1.0

Conversation

@david-ruiz-cko

@david-ruiz-cko david-ruiz-cko commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

This release adds full support for Bacs Direct Debit to the SDK, including API client, documentation, endpoint registration, and integration tests. It also expands and clarifies documentation for bank instrument creation, retrieval, updating, and payment flows, especially for Bacs, SEPA, and ACH. Finally, it enhances the method for retrieving bank account field requirements with new filtering options.

Bacs Direct Debit Support:

  • Added a new Bacs class (src/api/apm-specific/bacs.js) to support sending Bacs Direct Debit pre-notifications via the /apms/bacs/notifications endpoint. This includes detailed request/response documentation and error handling.
  • Registered the Bacs endpoint in the SDK factory (src/endpoints-factory.js), main index (src/index.js), and updated the README to document access via cko.bacs. [1] [2] [3]
  • Added integration tests for Bacs pre-notification, including positive and negative cases (test/apm-specific/bacs-it.js).

Bank Instrument Documentation Improvements:

  • Expanded and clarified JSDoc comments for instrument creation, retrieval, and updating in src/api/instruments/instruments.js, with detailed field requirements and response shapes for Bacs, SEPA, and ACH variants. [1] [2] [3]

Bank Account Field Formatting Enhancements:

  • Enhanced getBankAccountFieldFormatting to accept optional filters (accountHolderType and paymentNetwork), supporting both camelCase and hyphenated parameter names.

Payments API Documentation:

  • Updated src/api/payments/payments.js documentation to clarify how to use Bacs and SEPA sources for payments, including required fields and API quirks.

@david-ruiz-cko
david-ruiz-cko requested a review from a team September 4, 2026 10:01
@agent-wall-e

agent-wall-e Bot commented Sep 4, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • 2.2.7_dependency_upgrade

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Sep 4, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
2.2.7_dependency_upgrade classifying §2.2.7 All files are manifest + lockfile, and no security-sensitive package was touched.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2026

Copy link
Copy Markdown

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • 2.2.7_dependency_upgrade

wall-e 2026.06.19-02 · policy 376219bc71e6…

@david-ruiz-cko
david-ruiz-cko merged commit 771e3b9 into master Sep 7, 2026
3 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the release/5.1.0 branch September 7, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants