Skip to content

Release 8.2.0 - Top-up instructions and amount allocations - #665

Merged
david-ruiz-cko merged 1 commit into
masterfrom
release/8.2.0
Sep 10, 2026
Merged

Release 8.2.0 - Top-up instructions and amount allocations#665
david-ruiz-cko merged 1 commit into
masterfrom
release/8.2.0

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This release adds support for retrieving top-up instructions for currency accounts (sub-accounts) via the balances API, including both asynchronous and synchronous methods. It introduces new data models for top-up instructions and bank details, updates the OAuth scopes, and improves documentation across balances-related classes. Comprehensive unit tests for the new functionality are also included.

New API Functionality:

  • Added asynchronous and synchronous methods to BalancesClient and BalancesClientImpl for retrieving top-up instructions (retrieveTopUpInstructions and retrieveTopUpInstructionsSync), including input validation and endpoint path construction. [1] [2]
  • Introduced new response and model classes: TopUpInstructionsResponse, TopUpBankDetails, and TopUpFundingDetails to represent top-up instructions and associated bank details. [1] [2] [3]

Authorization & Scopes:

  • Added the BALANCES_TOP_UP_INSTRUCTIONS OAuth scope to both the enum and test fixture setup to support the new endpoint. [1] [2]

Documentation Improvements:

  • Enhanced Javadoc comments for Balances, BalancesResponse, and CurrencyAccountBalance to clarify the purpose and optionality of fields. [1] [2] [3] [4]

Testing:

  • Expanded BalancesClientImplTest to cover the new top-up instructions methods, including positive tests and parameterized negative tests for input validation. [1] [2] [3] [4] [5]

@david-ruiz-cko
david-ruiz-cko requested a review from a team September 10, 2026 09:18
@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Sep 10, 2026

Copy link
Copy Markdown

🔵 Advisory review: Sound, but needs your judgement

This PR needs a human approval. The code itself reads as correct; whether it should land depends on context I don't have.

The diff shown contains only the version bump from 8.1.0 to 8.2.0 in gradle.properties; the PR description claims significant new functionality (new API methods, model classes, OAuth scopes, tests) but none of that code is visible in the provided diff, making it impossible to verify the claims.

For you to decide

  • The diff is partial — only gradle.properties is shown, but the PR description references multiple new files and changes across BalancesClient, TopUpInstructionsResponse, TopUpBankDetails, TopUpFundingDetails, OAuthScope, and test classes that are not present in the diff provided for review.
  • A human reviewer must verify that all the claimed new functionality (retrieveTopUpInstructions async/sync methods, new model classes, BALANCES_TOP_UP_INSTRUCTIONS scope, expanded tests) is actually present and correct in the full changeset before approving.
  • The version bump itself (8.1.0 → 8.2.0) is consistent with a minor feature release as described, but cannot be validated as correct without seeing the full diff.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

@david-ruiz-cko
david-ruiz-cko merged commit 427d672 into master Sep 10, 2026
6 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the release/8.2.0 branch September 10, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants