Repository navigation
api!: get rid of Qr::FprWithoutAddr and Qr::FprMismatch variants - #8719
Conversation
b2c86b8 to
527570b
Compare
|
Since we're on it, can we remove |
527570b to
0c28ecf
Compare
| let (contact_id, _) = | ||
| Contact::add_or_lookup_ext(context, "", addr, &fingerprint, Origin::UnhandledQrScan) | ||
| .await?; | ||
| let contact = Contact::get_by_id(context, contact_id).await?; |
There was a problem hiding this comment.
Removed checking for the public key while removing FprMismatch, so it is now possible to get FprOk that points to the chat where you cannot send if you somehow added a key contact without the key. I did not want to return a separate error for the case when the contact exists, but has no key. I think it's fine because fingerprint-only QR codes are not really used anyway.
link2xt
changed the title
Qr::FprMismatch variants
link2xt
changed the title
Qr::FprMismatch variants
Hocuri
left a comment
Hocuri
left a comment
There was a problem hiding this comment.
Nice to remove some more historical baggage!
"BREAKING CHANGES:" footer in the Commit message needs to be updated since both variants are removed now
We don't look at the address in OPENPGP4FPR QR codes anymore. If we cannot find a contact by fingerprint, then we return an error without trying to look up the contact by address. Scanning OPENPGP4FPR can now only return FprOk if matching key-contact is found, or an error. BREAKING CHANGE: removed DC_QR_FPR_WITHOUT_ADDR and DC_QR_FPR_MISMATCH constants from CFFI BREAKING CHANGE: removed FprWithoutAddr and FprMismatch variants from JSON-RPC QrObject returned by check_qr
0c28ecf to
8fe31cc
Compare
2 participants
We don't look at the address in OPENPGP4FPR QR codes anymore.
If we cannot find a contact by fingerprint,
then we return an error without trying to look up
the contact by address.
Scanning OPENPGP4FPR can now only return FprOk
if matching key-contact is found, or an error.
BREAKING CHANGE: removed DC_QR_FPR_WITHOUT_ADDR and DC_QR_FPR_MISMATCH constants from CFFI
BREAKING CHANGE: removed FprWithoutAddr and FprMismatch variants from JSON-RPC QrObject returned by check_qr