feat: ignore Chat-Disposition-Notification-To value - #8681
Open
link2xt wants to merge 1 commit into
Open
Conversation
link2xt
force-pushed
the
link2xt/ignore-chat-disposition-notification-to-value
branch
from
September 10, 2026 22:51
9c5ae2c to
44270d7
Compare
link2xt
changed the title
link2xt
force-pushed
the
link2xt/ignore-chat-disposition-notification-to-value
branch
from
September 10, 2026 22:57
44270d7 to
0d885c4
Compare
link2xt
marked this pull request as ready for review
September 10, 2026 23:23
link2xt
commented
Sep 10, 2026
|
|
||
| /// Test that From with multiple addresses is not allowed. | ||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn test_parse_first_addr() { |
Collaborator
Author
There was a problem hiding this comment.
This test is from 09c7ab1 and was testing something different back then and checking that the first address is used. I kept the test just to avoid deleting tests, but it is now testing the opposite of what it was testing originally when the test was introduced.
link2xt
changed the title
Main change is the removal of the comparison of Chat-Disposition-Notification-To to the From header for incoming messages. Removed code that was settting WantsMdn for outgoing messages is a leftover not cleaned up in ade39fe We do not actually use WantsMdn for outgoing messages.
link2xt
force-pushed
the
link2xt/ignore-chat-disposition-notification-to-value
branch
from
September 11, 2026 03:18
0d885c4 to
b2d482d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change is the removal of the comparison of Chat-Disposition-Notification-To to the From header for incoming messages.
Removed code that was settting WantsMdn for outgoing messages is a leftover not cleaned up in ade39fe We do not actually use WantsMdn for outgoing messages.