Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
resizeDelayis set, the delayed resize runschart.update(['resize'])instead ofchart.update('resize').Root cause:
debounceinsrc/helpers/helpers.extras.tsschedules the delayed call withsetTimeout(fn, delay, args).setTimeoutpasses its extra parameters tofnone by one, sofngets the wholeargsarray as its first argument. The branch without a delay usesfn.apply(this, args), so the two paths disagree. Because of this, the update hooks give pluginsargs.modeas['resize'], scriptable options seecontext.modeas an array, and checks likemode !== 'resize'in the radar controller take the wrong branch.Fix: spread the arguments,
setTimeout(fn, delay, ...args), so the delayed call gets the same arguments as the direct one.Test: a new spec in
test/specs/core.controller.tests.jssetsresizeDelay: 10, resizes the wrapper and expectschart.updateto have been called with'resize'. It fails before the fix (the only call was[ [ 'resize' ] ]) and passes after.