fix(types): parameterize RadarController with its 'radar' chart type - #12318
Open
marina-semeia wants to merge 1 commit into
Open
marina-semeia wants to merge 1 commit into
marina-semeia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RadarControlleris declared as the unparameterizedDatasetController, so itsTTypefalls back to the genericChartType:As a result, a subclass of
RadarControllerloses radar-specific typing. For example,getParsed()returns the union of all parsed data types instead ofRadialParsedData:This is a common need when extending the radar controller (e.g. to position points between grid lines instead of on them).
Changes
RadarControlleris nowDatasetController<'radar'>insrc/types/index.d.ts.test/types/controllers/radar_controller_subclass.ts(fails withTS2339without the fix, passes with it).Note
The other built-in controllers (
BarController,LineController,BubbleController,DoughnutController, …) are declared the same unparameterized way. I kept this PR scoped toRadarController, but I'm happy to extend it to the others if you'd prefer a consistent change.