Conversation
Cover aligned text and symbols while preserving RTL positioning. Add rendered-label regression coverage. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertical legends can draw a short center- or right-aligned label outside its clickable area. Compute the hitbox from the union of the symbol and the aligned text, honoring per-item alignment and RTL positioning.
Fixes #12067.
Adds regression coverage for every legend position, left/center/right alignment, RTL, and per-item alignment. Eight alignment cases fail on the original code. The tests check the rendered text edges and symbol centers.
Validation on the fork:
controller.polarArea/pointLabels/overlapping.js, reproduced on the unchanged base in the same runner with the identical 293-pixel difference (0.11%, tolerance 0.1%). The fixture and tolerance are unchanged.This change and its tests were developed with OpenAI Codex.