Skip to content

fix(studio): simplify editing and preserve pending actions - #218

Merged
chamsechan merged 1 commit into
mainfrom
fix/studio-edit-completion
Oct 26, 2026
Merged

chamsechan merged 1 commit into
mainfrom
fix/studio-edit-completion

Conversation

@chamsechan

@chamsechan chamsechan commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Pipeline Studio now edits and saves a single Pipeline JSON document directly. Users can save incomplete work without runtime tools or model assets; native validation remains mandatory before execution. Deployment association and paired .conf saving have been removed, while trial runs continue through temporary files and the existing Operator/Demo path.

The editor applies ordinary parameter changes automatically, provides structured keyword/rule forms, and supports click or drag connections with snapping and keyboard controls. Saving immediately after a node rename waits for that edit and completes with one click. Invalid node and I/O drafts can be discarded without losing completed changes, and validation opens and focuses hidden invalid fields. Redundant run freshness state and the unused automatic Profile selection path are removed.

Validation:

  • Canonical local quality gate: 466 passed, 5 optional real-asset tests skipped, 0 failed.
  • Real Chromium regression enabled locally: delayed rename followed by one Save, invalid draft focus/discard, I/O rollback, result freshness, connections, three desktop layouts, and the real keyword Demo.
  • The 5 optional local skips require Inferlet model/vision assets or real BPE tokenizer assets. First-use usability, touch interaction, and very large graph performance remain outside automated acceptance.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T09:34:49.673884Z 0db4d5f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chamsechan
chamsechan merged commit de6306f into main Oct 26, 2026
8 checks passed
@chamsechan
chamsechan deleted the fix/studio-edit-completion branch October 26, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant