Repository navigation
refactor(nodes): unify node authoring on one structure - #213
Merged
Merged
Conversation
Every business Node already shares MakeNodeSpec + REGISTER_FUNCTION_NODE; the authoring surface now presents it that way. - scaffold: drop --kind and the five generation branches; one render_node emits Inputs, optional Params/Models, Run and Spec. -m adds one model, --control-id adds Params and a Control command. Remove the starter_llm/starter_control templates. - tests: add tests/support/recording_models.h (serialized fixture models for all five capabilities); generated tests drop restated Definition assertions and inline fakes; llm_generate and prompt_guided_llm tests use the shared RecordingLlm. - guard: check_layer_dependencies.py rejects NodeBase, INode and NodeRegistry in common/custom Node code after stripping comments and literals, covering qualified, multi-line, implicit and aliased spellings. - docs: first_custom_node.md walks a model-free Node first, then the same structure with an LLM; Run is the only required logic, helpers are optional. Update Control guide, concepts, layout, READMEs and skill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified by the repository's canonical local quality gate.
🤖 Generated with Claude Code