-
Notifications
You must be signed in to change notification settings - Fork 53
fix(dispatcher): improve fanout delivery timeouts and retry budget #3270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
migmartri
wants to merge
4
commits into
chainloop-dev:main
Choose a base branch
from
migmartri:dw/5173-1783416967
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
11a7079
fix(dispatcher): improve fanout delivery timeouts and retry budget
migmartri e16b9b2
fix(webhook): bump plugin version to 1.2
migmartri 5bd7613
docs: clarify Assisted-by trailer must name the actual AI tool
migmartri 799b8d2
refactor(dispatcher): keep per-attempt timeout in webhook plugin, not…
migmartri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
app/controlplane/internal/dispatcher/dispatch_timeout_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| // | ||
| // Copyright 2026 The Chainloop Authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package dispatcher | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "io" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/chainloop-dev/chainloop/app/controlplane/plugins/sdk/v1" | ||
| mockedSDK "github.com/chainloop-dev/chainloop/app/controlplane/plugins/sdk/v1/mocks" | ||
| "github.com/go-kratos/kratos/v2/log" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/mock" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| // setMaxDispatchElapsedTimeForTest temporarily shrinks the total retry | ||
| // budget so tests don't wait for the real 5m. The returned func restores | ||
| // the production value. | ||
| func setMaxDispatchElapsedTimeForTest(d time.Duration) func() { | ||
| prev := maxDispatchElapsedTime | ||
| maxDispatchElapsedTime = d | ||
| return func() { maxDispatchElapsedTime = prev } | ||
| } | ||
|
|
||
| // TestDispatchSucceedsOnRetry verifies that a transient failure followed by | ||
| // success stops the retry loop and returns nil. | ||
| func TestDispatchSucceedsOnRetry(t *testing.T) { | ||
| // Safety net: if the mock setup is wrong, fail fast instead of waiting 5m. | ||
| restore := setMaxDispatchElapsedTimeForTest(2 * time.Second) | ||
| t.Cleanup(restore) | ||
|
|
||
| plugin := mockedSDK.NewFanOut(t) | ||
| plugin.On("String", mock.Anything).Return("test-plugin").Maybe() | ||
|
|
||
| // First call fails, second call succeeds. .Once() ensures each | ||
| // expectation is consumed exactly once, so the second call returns nil. | ||
| plugin.On("Execute", mock.Anything, mock.Anything).Return(errors.New("transient failure")).Once() | ||
| plugin.On("Execute", mock.Anything, mock.Anything).Return(nil).Once() | ||
|
|
||
| logger := log.NewHelper(log.NewStdLogger(io.Discard)) | ||
| opts := &sdk.ExecutionRequest{ | ||
| Input: &sdk.ExecuteInput{ | ||
| Attestation: &sdk.ExecuteAttestation{}, | ||
| }, | ||
| } | ||
|
|
||
| err := dispatch(context.Background(), plugin, opts, logger) | ||
| require.NoError(t, err) | ||
|
|
||
| var execCalls int | ||
| for _, c := range plugin.Calls { | ||
| if c.Method == "Execute" { | ||
| execCalls++ | ||
| } | ||
| } | ||
| assert.Equal(t, 2, execCalls, "should have called Execute exactly twice") | ||
| } | ||
|
|
||
| // TestDispatchNoInput verifies the fast-fail path that doesn't enter the retry loop. | ||
| func TestDispatchNoInput(t *testing.T) { | ||
| plugin := mockedSDK.NewFanOut(t) | ||
| logger := log.NewHelper(log.NewStdLogger(io.Discard)) | ||
| opts := &sdk.ExecutionRequest{Input: &sdk.ExecuteInput{}} | ||
|
|
||
| err := dispatch(context.Background(), plugin, opts, logger) | ||
| require.Error(t, err) | ||
| assert.Contains(t, err.Error(), "no input provided") | ||
| plugin.AssertNotCalled(t, "Execute", mock.Anything, mock.Anything) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Canceled dispatches can keep retrying until the full 5-minute retry budget because the retry policy is no longer wrapped with the parent context. Using backoff.WithContext(b, ctx) here preserves the longer retry budget while stopping promptly when the caller cancels.
Prompt for AI agents