Skip to content

ENT-11586: Move build host provisioning to testing-pr (fix-buildhost.sh) #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickanderson wants to merge 1 commit into from
Closed

ENT-11586: Move build host provisioning to testing-pr (fix-buildhost.sh) #2283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ci/fix-buildhost.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,12 @@ fi
if command -v yum >/dev/null 2>/dev/null; then
sudo yum erase -y openssl-devel || true
fi

# ENT-11586: provision the build host here, in the testing-pr job, instead of in
# the Amazon EC2 init script, so failures are visible in the build log and fail
# the build. Run on every build (setup is idempotent) so a PR can change build
# host setup and a later build reverts it. setup-cfengine-build-host.sh is
# Linux-only and must run as root; exotic hosts are provisioned out-of-band.
if [ "$(uname)" = "Linux" ]; then
sudo "$my_dir"/setup-cfengine-build-host.sh
fi
Comment on lines +51 to +54

@craigcomstock craigcomstock Jun 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer this "only linux" stuff to not be here. Just call the script and that should be good enough. Leaves us room to adjust the setup-cfengine-build-host.sh as appropriate.

There are several "gates" in the setup-cfengine-build-host.sh script to bail with exit 1 in case the Linux distribution is unsupported or the platform is not even Linux. Thanks for the adjustment!

Loading