Repository navigation
Widen Z3 verifier duration bounds to match google.protobuf.Duration. - #1436
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Align `CelVerifier` Z3 duration bounds and witness formatting with CEL specification PR #501, which widens CEL durations from signed 64-bit nanoseconds to the full `google.protobuf.Duration` range (±10,000 years, -315,576,000,000.999999999s to +315,576,000,000.999999999s). Constrain Z3 duration variables and duration arithmetic overflow checks to the ±10,000-year nanosecond bounds instead of 64-bit integer bounds, and format Z3 duration witnesses via `ProtoTimeUtils.formatDuration` so multi-millennia durations remain valid CEL `duration(...)` literals instead of overflowing `ns` integer parsing. PiperOrigin-RevId: 1010948096
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen Z3 verifier duration bounds to match google.protobuf.Duration.
Align
CelVerifierZ3 duration bounds and witness formatting with CEL specification PR #501, which widens CEL durations from signed 64-bit nanoseconds to the fullgoogle.protobuf.Durationrange (±10,000 years, -315,576,000,000.999999999s to +315,576,000,000.999999999s).Constrain Z3 duration variables and duration arithmetic overflow checks to the ±10,000-year nanosecond bounds instead of 64-bit integer bounds, and format Z3 duration witnesses via
ProtoTimeUtils.formatDurationso multi-millennia durations remain valid CELduration(...)literals instead of overflowingnsinteger parsing.