Repository navigation
Validate Duration and Timestamp bounds on CEL message construction. - #1435
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
CEL specification PR #501 requires constructing `google.protobuf.Duration` or `google.protobuf.Timestamp` message literals with out-of-range `seconds` or `nanos` fields (or mismatched signs on `Duration`) to fail at evaluation time, while preserving unvalidated field selection on existing protobuf messages. Validate built `Duration` and `Timestamp` protobuf instances during CEL struct literal creation in both value-provider and legacy descriptor-provider runtimes, update the interpreter wrapper baseline, and remove `_TESTS_TO_SKIP_SPEC_IMPORT` now that all duration and wrapper conformance tests pass. PiperOrigin-RevId: 1010948097
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate Duration and Timestamp bounds on CEL message construction.
CEL specification PR #501 requires constructing
google.protobuf.Durationorgoogle.protobuf.Timestampmessage literals with out-of-rangesecondsornanosfields (or mismatched signs onDuration) to fail at evaluation time, while preserving unvalidated field selection on existing protobuf messages.Validate built
DurationandTimestampprotobuf instances during CEL struct literal creation in both value-provider and legacy descriptor-provider runtimes, update the interpreter wrapper baseline, and remove_TESTS_TO_SKIP_SPEC_IMPORTnow that all duration and wrapper conformance tests pass.