Repository navigation
Widen CEL durations to match google.protobuf.Duration bounds. - #1434
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1010820757
branch
2 times, most recently
from
October 31, 2026 00:20
3ce2d1a to
0920c81
Compare
CEL specification PR #501 widens valid CEL durations from roughly ±290 years (64-bit signed nanoseconds) to the full `google.protobuf.Duration` range (±10,000 years, -315,576,000,000.999999999s to +315,576,000,000.999999999s) so every difference between valid `Timestamp` values is representable as a CEL duration. Update duration bounds checking, timestamp and duration arithmetic, and `timestamp(int)` epoch-second validation across both native `java.time` and protobuf runtime representations. Replace `threeten-extra` duration parsing with a zero-allocation Go `time.ParseDuration`-compatible parser supporting the ±10,000-year range (removing the `org.threeten:threeten-extra` dependency), deprecate `CelOptions.Builder.enableTimestampOverflowCheck` as a no-op, and enable the widened duration conformance tests. PiperOrigin-RevId: 1010820757
copybara-service
Bot
force-pushed
the
test_1010820757
branch
from
October 31, 2026 02:40
0920c81 to
bd5ed37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen CEL durations to match google.protobuf.Duration bounds.
CEL specification PR #501 widens valid CEL durations from roughly ±290 years (64-bit signed nanoseconds) to the full
google.protobuf.Durationrange (±10,000 years, -315,576,000,000.999999999s to +315,576,000,000.999999999s) so every difference between validTimestampvalues is representable as a CEL duration.Update duration bounds checking, timestamp and duration arithmetic, and
timestamp(int)epoch-second validation across both nativejava.timeand protobuf runtime representations. Replacethreeten-extraduration parsing with a zero-allocation Gotime.ParseDuration-compatible parser supporting the ±10,000-year range (removing theorg.threeten:threeten-extradependency), deprecateCelOptions.Builder.enableTimestampOverflowCheckas a no-op, and enable the widened duration conformance tests.