add requirements tracking with duvet - #2
Open
victornicolet wants to merge 4 commits into
Open
Conversation
Signed-off-by: Victor Nicolet <victornl@amazon.com>
Signed-off-by: Victor Nicolet <victornl@amazon.com>
Member
Author
|
The RFC coverage check will fail until we have proven "completeness" for the parser. |
Signed-off-by: Victor Nicolet <victornl@amazon.com>
victornicolet
force-pushed
the
victornicolet/tracking-with-duvet
branch
from
August 20, 2026 19:46
8060a4d to
4e0162d
Compare
Signed-off-by: Victor Nicolet <victornl@amazon.com>
victornicolet
force-pushed
the
victornicolet/tracking-with-duvet
branch
from
August 24, 2026 16:55
3eda681 to
05e5603
Compare
victornicolet
commented
Aug 24, 2026
| @@ -0,0 +1,91 @@ | |||
| SPECIFICATION: https://www.rfc-editor.org/rfc/rfc8259 | |||
Member
Author
There was a problem hiding this comment.
This is a generated file but I think it's worth keeping in git. We may want to see when tracking information changes (specs or implementation).
victornicolet
marked this pull request as ready for review
August 25, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds requirements tracking with duvet following up on @john-h-kastner-aws suggestion in #1.
The requirements are RFC 8259.
Splitting the requirements and assigning them to some code blocks can feel a little arbitrary when dealing with the low level properties (esp. tokenizer), but at least the high-level requirements are easier to track.
In particular, the coverage will fail since we don't prove the high-level requirement for completeness.
This PR doesn't change the functionality in any meaningful way. Some constants have been renamed to match the spec names, and a new module has been added to track some conformance facts explicitly in the code.