[Kokkos] Porting Op_Dift_VDF_Elem_base::calculer_dt_stab_elem - #22
Draft
fmgjcoppens wants to merge 9 commits into
Draft
[Kokkos] Porting Op_Dift_VDF_Elem_base::calculer_dt_stab_elem#22fmgjcoppens wants to merge 9 commits into
fmgjcoppens wants to merge 9 commits into
Conversation
fmgjcoppens
marked this pull request as draft
July 24, 2026 14:52
fmgjcoppens
changed the title
Changed loop structure. Pulled out the branch for !is_concentration and put the loops inside it. Regression tests still pass.
Final value of `coef` is infinite, after the parallel reduction is finished.
fmgjcoppens
force-pushed
the
coppens/port_Op_Dift_VDF_Elem_base__calculer_dt_stab_elem
branch
from
July 27, 2026 14:41
4d790b7 to
66faeca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Kokkos port of Op_Dift_VDF_Elem_base::calculer_dt_stab_elem
Regression tests do not all pass.
Comparing last iteration of the first function call of the reference branch and the development branch (using test case
QC_Turb_VDF_diff_impl):Some executions there are only 3 function calls instead of 23. In this case the values of the variables in both cases match up, but only for the first call: