Add predicate queued to taskRun to indicate that task is planned to be started in future#317
Open
BaLiKfromUA wants to merge 5 commits into
Open
Add predicate queued to taskRun to indicate that task is planned to be started in future#317BaLiKfromUA wants to merge 5 commits into
queued to taskRun to indicate that task is planned to be started in future#317BaLiKfromUA wants to merge 5 commits into
Conversation
0747fcb to
8600499
Compare
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net>
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net>
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net>
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net>
Signed-off-by: vyuhimenko <vyuhimenko@bloomberg.net>
498697b to
b45a092
Compare
Author
|
Validated JSONs locally: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #305
This PR introduces a new
taskRunpredicate:queued.Consistent with other queued events, this predicate indicates that a task is waiting for the applicable preconditions to be satisfied before it can start running.
This is needed for two reasons:
There is currently a small inconsistency between the predicates available for
taskRunand the kinds of work that a task can represent. ThetestSuiteRunsubject from Testing Events already supports aqueuedpredicate. Since a task can represent a test run, addingqueuedtotaskRunseems consistent with the specification:There is currently no way to express a
taskRunthat has been scheduled for future execution but has not started yet. For example, apipelineRunmay already be started and in progress while one of itstaskRuns is still queued.Note: As of July 2026, there is an ongoing discussion about introducing a separate Scheduler abstraction in CDEvents. Such an addition would not conflict with this PR. In the meantime, the
queuedpredicate can serve as a practical compromise.As an example for making this contribution, I've been using #145
Submitter Checklist
As the author of this PR, please check off the items in this checklist: