Skip to content

fix(ports): prevent goroutine leak when context is cancelled in ScanPorts - #164

Open
mendsec wants to merge 1 commit into
developfrom
fix-ports-goroutine-leak-11991126509079483471
Open

mendsec wants to merge 1 commit into
developfrom
fix-ports-goroutine-leak-11991126509079483471

Conversation

@mendsec

@mendsec mendsec commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

What: Fixed a goroutine leak in pkg/ports/scanner.go where worker goroutines could block indefinitely on a channel send if the context was cancelled and the consumer stopped reading.
Why: Context cancellation must correctly tear down all resources to prevent memory/goroutine leaks.
Impact: Eliminates goroutine leaks on premature scan cancellations.
Measurement: Verified via runtime.NumGoroutine() delta in TestScanPortsPrematureCancel.
Closes Issue #105. RDP probe implemented in v0.4.0 via TPKT/X.224 CR in GrabBanners. SNMP deferred to Milestone 6 — requires UDP transport layer in pkg/ports (current engine is TCP-only). Tracked in #[new issue number].


PR created automatically by Jules for task 11991126509079483471 started by @mendsec

…orts

Co-authored-by: mendsec <12684528+mendsec@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions
github-actions Bot deleted the fix-ports-goroutine-leak-11991126509079483471 branch November 8, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant